Code Refactoring: Move delta-sharing-client out as a separate directory #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlenelyu-db
approved these changes
Jun 26, 2023
chakankardb
reviewed
Jun 27, 2023
client/src/main/scala/io/delta/sharing/client/filters/JsonPredicates.scala
Outdated
Show resolved
Hide resolved
client/src/main/scala/io/delta/sharing/client/filters/OpConverter.scala
Outdated
Show resolved
Hide resolved
| @@ -14,7 +14,7 @@ | |||
| * limitations under the License. | |||
| */ | |||
|
|
|||
| package io.delta.sharing.spark.util | |||
| package io.delta.sharing.client.util | |||
There was a problem hiding this comment.
This seems odd. These are all spark confs. Why should they belong int the client?
There was a problem hiding this comment.
ConfUtils is actually used by DeltaSharingFileSystem, and used to initialize DeltaSharingRestClient in RemoteDeltaLog, I'll refactor that later as well.
There was a problem hiding this comment.
Having DeltaSharingFileSystem in the client seems a bit odd.
Why do we need it in the client?
There was a problem hiding this comment.
It was discussed in the design doc actually.
delta-sharing-client serves two main purposes: 1) DeltaSharingClient to handle http requests/responses 2) DeltaSharingFileSystem to handle reading data out of pre-signed urls.
chakankardb
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code Refactoring: Move delta-sharing-client out as a separate directory