Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pagination for QueryTable at snapshot #352

Merged
merged 2 commits into from
Jul 28, 2023
Merged

Pagination for QueryTable at snapshot #352

merged 2 commits into from
Jul 28, 2023

Conversation

charlenelyu-db
Copy link
Collaborator

@charlenelyu-db charlenelyu-db commented Jul 24, 2023 •
edited
Loading

  • Part 1: Pagination for QueryTable at snapshot
    • Part 2: Pagination for QueryTable from starting_version
      • Part 3: Pagination for QueryTableChanges

Support pagination for QueryTable at snapshot in reference server.

  • Add two optional fields maxFiles, pageToken in QueryTableRequest
  • Return nextPageToken json object in the response if maxFiles is specified
  • Page token is base-64 encoded, not encrypted
  • Add unit tests

This is part 1 for issue #351

This was referenced Jul 24, 2023
Merged
Merged
@charlenelyu-db charlenelyu-db mentioned this pull request Jul 26, 2023
Merged
@charlenelyu-db charlenelyu-db merged commit 1154fe7 into delta-io:main Jul 28, 2023
4 checks passed
@charlenelyu-db charlenelyu-db mentioned this pull request Aug 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linzhou-db linzhou-db linzhou-db approved these changes

@chakankardb chakankardb chakankardb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@charlenelyu-db @linzhou-db @chakankardb