Handle valueless query params

deltablue-cloud · Mar 9, 2017 · 280a968 · 280a968
1 parent 187ba51
commit 280a968
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/src/QueryParameterBag.php b/src/QueryParameterBag.php
@@ -21,7 +21,9 @@ public static function fromString(string $query = ''): QueryParameterBag
         }
 
         return new static(Arr::mapToAssoc(explode('&', $query), function (string $keyValue) {
-            return explode('=', $keyValue, 2);
+            $parts = explode('=', $keyValue, 2);
+
+            return count($parts) === 2 ? $parts : [$parts[0], null];
         }));
     }
 

diff --git a/tests/UrlQueryParametersTest.php b/tests/UrlQueryParametersTest.php
@@ -64,4 +64,20 @@ public function it_can_unset_a_query_parameter()
 
         $this->assertFalse($url->hasQueryParameter('offset'));
     }
+
+    /** @test */
+    public function it_can_handle_empty_query_parameters()
+    {
+        $url = Url::create()->withQuery('offset');
+
+        $this->assertTrue($url->hasQueryParameter('offset'));
+    }
+
+    /** @test */
+    public function empty_query_parameters_default_to_null()
+    {
+        $url = Url::create()->withQuery('offset');
+
+        $this->assertNull($url->getQueryParameter('offset'));
+    }
 }