Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use separate transaction storage for each DictProxy handler #393

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

link2xt
Copy link
Contributor

@link2xt link2xt commented Jul 31, 2024

DictProxy can have transactions with the same name (most frequently 1) processed in parallel.
Dovecot expects that transaction names on each connection are independent.

Fixes #392

@link2xt link2xt force-pushed the link2xt/store-transactions-per-handler branch 5 times, most recently from d3f3e02 to 9344f88 Compare July 31, 2024 17:43
DictProxy can have transactions with the same name
(most frequently `1`) processed in parallel.
Dovecot expects that transaction names on each connection
are independent.
@link2xt link2xt force-pushed the link2xt/store-transactions-per-handler branch from 9344f88 to f8ce1b1 Compare July 31, 2024 17:44
@link2xt link2xt requested a review from hpk42 July 31, 2024 17:45
Copy link
Contributor

@hpk42 hpk42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for finding and fixing the bug.

@link2xt link2xt merged commit 1f1d1fd into main Jul 31, 2024
6 checks passed
@link2xt link2xt deleted the link2xt/store-transactions-per-handler branch July 31, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transactions should be stored in dictproxy handler, not dictproxy
2 participants