Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set CAA record flags to 0 #411

Merged
merged 1 commit into from
Sep 15, 2024
Merged

Set CAA record flags to 0 #411

merged 1 commit into from
Sep 15, 2024

Conversation

link2xt
Copy link
Contributor

@link2xt link2xt commented Sep 13, 2024

Close #410

missytake
missytake approved these changes Sep 14, 2024
View reviewed changes
Copy link
Contributor

@missytake missytake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we change it like this, the next time someone who has already set up chatmail runs cmdeploy dns, it will recommend to set their perfectly fine 128 record to 0... that's a bit unfortunate, but probably fine. I don't think it will happen very often.

@link2xt link2xt merged commit a6bdbb7 into main Sep 15, 2024
6 checks passed
@link2xt link2xt deleted the link2xt/caa-flags-0 branch September 15, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@missytake missytake missytake approved these changes

@hpk42 hpk42 Awaiting requested review from hpk42

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set CAA record flags to 0
2 participants
@link2xt @missytake