-
-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improvement: scroll to new messages smoothly #4125
base: main
Are you sure you want to change the base?
Conversation
e4d11e2
to
200682f
Compare
Can you describe how to test and provoke "critical" behaviour?
|
I mean the behavior we observed in #4186, #3763, #3753. By "critical" I mean whether the occasional "scroll up" outweighs the niceness of the smooth scroll, and so whether we want to merge this, without making it an experimental setting.
Yes, it results in a "scrolled up" chat once every ~100 smooth scrolls. |
These bugs are all solved, so I still don't get what this PR fixes/improves Can you add a video like "before" and "after" |
TODO: - [ ] Test it and see if it gets stuck often enough for it to be critical. I have seen it happen a few times. Maybe for 1 out of 100 messages. - [ ] Think about putting behind an experimental setting?
200682f
to
a8a8302
Compare
Those are solved, but this MR might introduce them back (I mean, not those bugs precisely, but their effect of "scrolling up"). I edited the original post by adding a video. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected! I consider it an improvement since it becomes more obvious that a new message arrived although it introduces a bit more complexity to the MessageList component whis has ~940 lines now...
TODO:
for it to be critical. I have seen it happen a few times.
Maybe for 1 out of 100 messages.
Ok, I have an idea. Let's merge it, and if it's not good yet, then put it behind the setting.