fix borderless drag issues and add debug overlay to better test issues about draging area #4300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s visible. Unfortunatly that overlay is not on top of everything, because dialogs are rendered in the top layer, which is on top of the z-index system.
…ways be clickable
WofWca
reviewed
Nov 10, 2024
There was a problem hiding this comment.
I have checked that the added DragRegionOverlay is not relevant in production. But it would also be nice to not include its code in the production build.
As to essence of this MR: I haven't checked it thoroughly, because I'm not on Mac.
But in general not so many lines have been changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
red is
drag, green isno-drag.How to use: go into electron dev tools, execute
exp.showDragAreas()to toggle the overlay which makes drag areas visible.This is a useful tool to make the issues with it more tangible.
Fix some of the bugs:
todo? or make new issue:
closes #4018
closes #3926