-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Proxy-Screen #2388
base: main
Are you sure you want to change the base?
Add Proxy-Screen #2388
Conversation
For whatever reasons this doesn't work in the simulator. Will investigate further, but it took me some time to figure that out.
…n selecting a proxy (#2382)
Xcode 16 broke something here so that Github Actions decided not to build any longer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice! 👍 i did not yet manage to fine a today working proxy (cc @adbenitez do you have one :), some nitpicking below, and some comments on the UI:
-
the "connecting..." and connected information are missing, afaik, there is no special "proxy connectivity", but android just repeats what is otherwise written beside "connectivity" (so the "global state"), however, this is an important information to have in that dialog when testing out if a proxy works
-
the "protocol" should not just be a string, let's put that into a square box as on android, we can use the same style as
-
when there are no proxies, android does not disable the switch, but allows to turn it on and shows the "Add Proxy" dialog - i think, this is a bit more user friendlyEDIT: it is fine as is
point 1. seems quite important, i would add that to this pr, so the user gets some some feedback, otherwise one is quite blind. also, disabling owner-verification should go to this PR
the other points can also come later, the dialog is also a huge things without 2.+3. - and there are more things to do for proxy beside polishing :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, it starts working :)
first times, we have a proxy connection on iOS :)
a bug i encountered during testing:
- add a proxy, tap a second time to activate (that should not be needed, added proxies should become automatically the active one)
-> the proxy is shown twice in the list
usability-wise, in general, a simple tap on a proxy can start using the proxy already. no need for a confirmation. things are easily undoable.
both are shown issues are shown in the following video:
RPReplay_Final1731425144.mov
with the "not-disable-switch but show add-screen" i mentioned on first review: we can leave things as is, the "add proxy" is easy enough, even though it is different on android
ss://[email protected]:443#Switzerland%20#1270%20/%20OutlineKeys.com ss://[email protected]:443#Switzerland%20%231309%20%2F%20OutlineKeys%2Ecom |
Screenshots