Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Proxy-Screen #2388

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Add Proxy-Screen #2388

wants to merge 20 commits into from

Conversation

zeitschlag
Copy link
Collaborator

@zeitschlag zeitschlag commented Nov 5, 2024

  • Advanced Settings gained a new entry (Proxy) under Server. This settings lives behind the Passcode/Biometrics-protection.
  • Adds a new screen to see, add, and delete proxy-servers (Swipe to delete only works on device, not in the simulator, but trust me, it's there!). Looks like this:
Screenshots

Simulator Screenshot - iPhone 16 Pro - 2024-11-12 at 13 01 14

Simulator Screenshot - iPhone 16 Pro - 2024-11-12 at 13 02 25

@zeitschlag zeitschlag linked an issue Nov 5, 2024 that may be closed by this pull request
3 tasks
@zeitschlag zeitschlag changed the title [WIP] 2382 advanced settings proxy Add Proxy-Screen Nov 7, 2024
@zeitschlag zeitschlag requested a review from r10s November 8, 2024 12:30
@zeitschlag zeitschlag marked this pull request as ready for review November 8, 2024 12:30
Copy link
Member

@r10s r10s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice! 👍 i did not yet manage to fine a today working proxy (cc @adbenitez do you have one :), some nitpicking below, and some comments on the UI:

  1. the "connecting..." and connected information are missing, afaik, there is no special "proxy connectivity", but android just repeats what is otherwise written beside "connectivity" (so the "global state"), however, this is an important information to have in that dialog when testing out if a proxy works

  2. the "protocol" should not just be a string, let's put that into a square box as on android, we can use the same style as

  3. when there are no proxies, android does not disable the switch, but allows to turn it on and shows the "Add Proxy" dialog - i think, this is a bit more user friendly EDIT: it is fine as is

point 1. seems quite important, i would add that to this pr, so the user gets some some feedback, otherwise one is quite blind. also, disabling owner-verification should go to this PR

the other points can also come later, the dialog is also a huge things without 2.+3. - and there are more things to do for proxy beside polishing :)

deltachat-ios/Helper/Utils.swift Outdated Show resolved Hide resolved
@zeitschlag zeitschlag requested a review from r10s November 12, 2024 12:03
Copy link
Member

@r10s r10s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, it starts working :)

first times, we have a proxy connection on iOS :)

a bug i encountered during testing:

  • add a proxy, tap a second time to activate (that should not be needed, added proxies should become automatically the active one)
    -> the proxy is shown twice in the list

usability-wise, in general, a simple tap on a proxy can start using the proxy already. no need for a confirmation. things are easily undoable.

both are shown issues are shown in the following video:

RPReplay_Final1731425144.mov

with the "not-disable-switch but show add-screen" i mentioned on first review: we can leave things as is, the "add proxy" is easy enough, even though it is different on android

@adbenitez
Copy link
Member

i did not yet manage to fine a today working proxy

ss://[email protected]:443#Switzerland%20#1270%20/%20OutlineKeys.com

ss://[email protected]:443#Switzerland%20%231309%20%2F%20OutlineKeys%2Ecom

@zeitschlag zeitschlag requested a review from r10s November 13, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proxy: Add Proxy-screen to advanced settings
3 participants