Fix pager duty test #2653
Merged
Fix pager duty test #2653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added box_files_get and box_files_get_info commands
removed unfinished box_files_upload for current content release
global vars are now in uppercase deleted unnecessary vars in getFiles()
global vars are now in uppercase deleted unnecessary vars in getFiles()
removed fixed tests
# Conflicts: # Tests/conf.json
ronykoz
suggested changes
Dec 17, 2018
| @@ -927,6 +928,6 @@ script: | |||
| description: Acknowledges an existing event in PagerDuty | |||
| isfetch: true | |||
| runonce: false | |||
| releaseNotes: "Adding PagerDuty-acknowledge-event, PagerDuty-resolve-event commands" | |||
| releaseNotes: "BruteTest" | |||
There was a problem hiding this comment.
restore the old RN, @Itay4 how come we did not release it?
ronykoz
approved these changes
Dec 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow, on some servers an empty list showed as null instead of empty list. fixed the test to check if a key is inside.