update-dockerfile-update-workflow #19147
Conversation
| echo "Approving and merging" | ||
| gh pr review --approve "$PR_URL" | ||
| gh pr merge --auto --squash "$PR_URL" | ||
| # - name: approve and merge |
| @@ -22,7 +23,7 @@ jobs: | |||
| GITHUB_TOKEN: ${{secrets.CONTENT_BOT_TOKEN}} | |||
| run: | | |||
| git fetch | |||
| branches=$(git branch -r | grep autoupdate/) | |||
| branches=$(git branch -r | grep TESTautoTESTupdate/) | |||
| @@ -1,10 +1,13 @@ | |||
| name: Update external base images | |||
| name: Update external base images test | |||
| except Exception as e: | ||
| print(f"{e}: Can't read file {file_path}") | ||
| if python_version: | ||
| full_str_python_version = python_version.group(0) |
There was a problem hiding this comment.
whats the difference? Why do we need both of these
There was a problem hiding this comment.
The full_str_python_version is "python_version= "3.9"" format, we need it in order to replace it in the pipfile/pyproject file.
The string_version_number is only the version 3.9
| echo "Approving and merging" | ||
| gh pr review --approve "$PR_URL" | ||
| gh pr merge --auto --squash "$PR_URL" | ||
| # - name: approve and merge |
| None | ||
| """ | ||
| update_result = False | ||
| image_name = dockerfile['image_name'] |
There was a problem hiding this comment.
if this is the case we will only update python. we want to update every image based on python as well
| return False | ||
|
|
||
|
|
||
| def change_python_version(file_path: str, str_version: str) -> Tuple[bool, str]: |
There was a problem hiding this comment.
this fn doesnt seem to do anything except log. Lets log that in the inner function and delete this 1
| if completed_process.returncode != 0: | ||
| os.chdir(current_directory) | ||
| return False | ||
| except subprocess.CalledProcessError as e: |
There was a problem hiding this comment.
collapese these catch blocks
There was a problem hiding this comment.
I need this block in order to get the stderr from the CalledProcessError (It creates a object with the data)
JudahSchwartz
dismissed
eyalpalo’s stale review
dismissing since Eyal is on vacation
|
Congrats on merging your first pull request! 🎉 How awesome! |
Status
In Progress
Related Content Pull Request
Related PR: link to the PR at demisto/content
Related Issues
Related: https://jira-hq.paloaltonetworks.local/browse/CIAC-7666
Description
migration of the Python version will trigger a GitHub workflow to open PRs and update the docker image, (update_dokcer_file in GitHub -> workflows -> update_internal/external_base_images utils/auto_dockerfile_update/update_dockerfiles.py)
in this workflow, we will add a mechanism to compare the base image in the docker file and the image tag in the pipfile/pyproject.tomal file, If we have an inequality we will update the pipfile and
run poetry-lock --no-update or pipfile lock --keep-outdated to update the python version in the pipfile.lock/poetry.lock file - this will keep the repo updated.