Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade CONSUL DEMOCRACY to version 2.1.1 #161

Merged
merged 62 commits into from
Apr 5, 2024
Merged

Upgrade CONSUL DEMOCRACY to version 2.1.1 #161

merged 62 commits into from
Apr 5, 2024

Commits on Feb 9, 2024

  1. Refactor regex in normalized_coordinates method to allow for whitespa…

    …ce between square brackets
    coslajohn committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    81d768f View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2024

  1. Bump puma from 5.6.7 to 5.6.8

    Bumps [puma](https://github.com/puma/puma) from 5.6.7 to 5.6.8.
    - [Release notes](https://github.com/puma/puma/releases)
    - [Changelog](https://github.com/puma/puma/blob/master/History.md)
    - [Commits](puma/puma@v5.6.7...v5.6.8)
    
    ---
    updated-dependencies:
    - dependency-name: puma
      dependency-type: direct:production
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    ac34657 View commit details
    Browse the repository at this point in the history
  2. Merge pull request consuldemocracy#5365 from consuldemocracy/dependab…

    …ot/bundler/puma-5.6.8
    
    Bump puma from 5.6.7 to 5.6.8
    javierm committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    07e4b8f View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. Bump Rails to version 6.1.7.7

    javierm committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    9ecab3b View commit details
    Browse the repository at this point in the history
  2. Merge pull request consuldemocracy#5401 from consuldemocracy/dependab…

    …ot/bundler/rails-6.1.7.7
    
    Bump rails from 6.1.7.6 to 6.1.7.7
    javierm committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    65ad182 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2024

  1. Bump rubocop-capybara from 2.19.0 to 2.20.0

    Note that this version changed the default enforced styles for
    ClickLinkOrButtonStyle and NegationMatcher, so we're now specifying
    them.
    
    Bumps [rubocop-capybara](https://github.com/rubocop/rubocop-capybara) from 2.19.0 to 2.20.0.
    - [Release notes](https://github.com/rubocop/rubocop-capybara/releases)
    - [Changelog](https://github.com/rubocop/rubocop-capybara/blob/main/CHANGELOG.md)
    - [Commits](rubocop/rubocop-capybara@v2.19.0...v2.20.0)
    
    ---
    updated-dependencies:
    - dependency-name: rubocop-capybara
      dependency-type: direct:development
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] authored and javierm committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    5772e1b View commit details
    Browse the repository at this point in the history
  2. Merge pull request consuldemocracy#5383 from consuldemocracy/dependab…

    …ot/bundler/rubocop-capybara-2.20.0
    
    Bump rubocop-capybara from 2.19.0 to 2.20.0
    javierm committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    4c4699c View commit details
    Browse the repository at this point in the history
  3. Bump rubocop-factory_bot from 2.24.0 to 2.25.1

    Bumps [rubocop-factory_bot](https://github.com/rubocop/rubocop-factory_bot) from 2.24.0 to 2.25.1.
    - [Release notes](https://github.com/rubocop/rubocop-factory_bot/releases)
    - [Changelog](https://github.com/rubocop/rubocop-factory_bot/blob/master/CHANGELOG.md)
    - [Commits](rubocop/rubocop-factory_bot@v2.24.0...v2.25.1)
    
    ---
    updated-dependencies:
    - dependency-name: rubocop-factory_bot
      dependency-type: direct:development
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    7fc40ef View commit details
    Browse the repository at this point in the history
  4. Merge pull request consuldemocracy#5385 from consuldemocracy/dependab…

    …ot/bundler/rubocop-factory_bot-2.25.1
    
    Bump rubocop-factory_bot from 2.24.0 to 2.25.1
    javierm committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    8c0c952 View commit details
    Browse the repository at this point in the history
  5. Bump rubocop-rspec from 2.24.1 to 2.27.0

    Bumps [rubocop-rspec](https://github.com/rubocop/rubocop-rspec) from 2.24.1 to 2.27.0.
    - [Release notes](https://github.com/rubocop/rubocop-rspec/releases)
    - [Changelog](https://github.com/rubocop/rubocop-rspec/blob/master/CHANGELOG.md)
    - [Commits](rubocop/rubocop-rspec@v2.24.1...v2.27.0)
    
    ---
    updated-dependencies:
    - dependency-name: rubocop-rspec
      dependency-type: direct:development
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    86b72ad View commit details
    Browse the repository at this point in the history
  6. Merge pull request consuldemocracy#5405 from consuldemocracy/dependab…

    …ot/bundler/rubocop-rspec-2.27.0
    
    Bump rubocop-rspec from 2.24.1 to 2.27.0
    javierm committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    ed24a16 View commit details
    Browse the repository at this point in the history
  7. Bump capybara from 3.39.2 to 3.40.0

    Bumps [capybara](https://github.com/teamcapybara/capybara) from 3.39.2 to 3.40.0.
    - [Changelog](https://github.com/teamcapybara/capybara/blob/master/History.md)
    - [Commits](teamcapybara/capybara@3.39.2...3.40.0)
    
    ---
    updated-dependencies:
    - dependency-name: capybara
      dependency-type: direct:development
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    139da18 View commit details
    Browse the repository at this point in the history
  8. Merge pull request consuldemocracy#5378 from consuldemocracy/dependab…

    …ot/bundler/capybara-3.40.0
    
    Bump capybara from 3.39.2 to 3.40.0
    javierm committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    5658b6f View commit details
    Browse the repository at this point in the history
  9. Update checkout action to version 3

    We were getting a warning with version 2:
    
    The following actions uses node12 which is deprecated and will be forced
    to run on node16: actions/checkout@v2. For more info:
    https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
    javierm committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    b60d2f4 View commit details
    Browse the repository at this point in the history
  10. Merge pull request consuldemocracy#5407 from consuldemocracy/update_c…

    …heckout_action
    
    Update checkout action to version 3
    javierm committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    e9af16f View commit details
    Browse the repository at this point in the history
  11. Update upload artifact action to version 3

    We were getting a warning with version 2:
    
    The following actions uses node12 which is deprecated and will be forced
    to run on node16: actions/upload-artifact@v2. For more info:
    https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
    javierm committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    e07650e View commit details
    Browse the repository at this point in the history
  12. Merge pull request consuldemocracy#5411 from consuldemocracy/update_u…

    …pload_artifact_action
    
    Update upload artifact action to version 3
    javierm committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    dc52673 View commit details
    Browse the repository at this point in the history
  13. Update checkout action to version 4

    We were getting some warnings with version 3:
    
    Node.js 16 actions are deprecated. Please update the following actions
    to use Node.js 20: actions/checkout@v3. For more information see:
    https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/
    javierm committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    3fa16bc View commit details
    Browse the repository at this point in the history
  14. Merge pull request consuldemocracy#5415 from consuldemocracy/update_c…

    …heckout_action_to_version_4
    
    Update checkout action to version 4
    javierm committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    fbe46c9 View commit details
    Browse the repository at this point in the history
  15. Update setup-node action to version 4

    We were getting a warning with version 3:
    
    Node.js 16 actions are deprecated. Please update the following actions
    to use Node.js 20: actions/setup-node@v3. For more information see:
    https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
    javierm committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    23e5489 View commit details
    Browse the repository at this point in the history
  16. Merge pull request consuldemocracy#5419 from consuldemocracy/update_s…

    …etup_node_action_to_version_4
    
    Update setup-node action to version 4
    javierm committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    1fe0393 View commit details
    Browse the repository at this point in the history
  17. Bump rubocop-rails from 2.21.2 to 2.23.1

    Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails) from 2.21.2 to 2.23.1.
    - [Release notes](https://github.com/rubocop/rubocop-rails/releases)
    - [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md)
    - [Commits](rubocop/rubocop-rails@v2.21.2...v2.23.1)
    
    ---
    updated-dependencies:
    - dependency-name: rubocop-rails
      dependency-type: direct:development
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    bbb4c84 View commit details
    Browse the repository at this point in the history
  18. Update upload artifact action to version 4

    We were getting a warning with version 3:
    
    Node.js 16 actions are deprecated. Please update the following actions
    to use Node.js 20: actions/upload-artifact@v3. For more information see:
    https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
    javierm committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    acfaada View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2024

  1. Merge pull request consuldemocracy#5362 from consuldemocracy/dependab…

    …ot/bundler/rubocop-rails-2.23.1
    
    Bump rubocop-rails from 2.21.2 to 2.23.1
    javierm committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    7ae8df8 View commit details
    Browse the repository at this point in the history
  2. Merge pull request consuldemocracy#5420 from consuldemocracy/update_u…

    …pload_artifact_action_to_version_4
    
    Update upload artifact action to version 4
    javierm committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    5624e0f View commit details
    Browse the repository at this point in the history
  3. Bump mdl from 0.12.0 to 0.13.0

    Bumps [mdl](https://github.com/mivok/markdownlint) from 0.12.0 to 0.13.0.
    - [Changelog](https://github.com/markdownlint/markdownlint/blob/main/CHANGELOG.md)
    - [Commits](markdownlint/markdownlint@v0.12.0...v0.13.0)
    
    ---
    updated-dependencies:
    - dependency-name: mdl
      dependency-type: direct:development
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    99b9167 View commit details
    Browse the repository at this point in the history
  4. Merge pull request consuldemocracy#5290 from consuldemocracy/dependab…

    …ot/bundler/mdl-0.13.0
    
    Bump mdl from 0.12.0 to 0.13.0
    javierm committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    70edfbe View commit details
    Browse the repository at this point in the history
  5. Bump factory_bot_rails from 6.2.0 to 6.4.3

    Bumps [factory_bot_rails](https://github.com/thoughtbot/factory_bot_rails) from 6.2.0 to 6.4.3.
    - [Release notes](https://github.com/thoughtbot/factory_bot_rails/releases)
    - [Changelog](https://github.com/thoughtbot/factory_bot_rails/blob/main/NEWS.md)
    - [Commits](thoughtbot/factory_bot_rails@v6.2.0...v6.4.3)
    
    ---
    updated-dependencies:
    - dependency-name: factory_bot_rails
      dependency-type: direct:development
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    56311ee View commit details
    Browse the repository at this point in the history
  6. Merge pull request consuldemocracy#5356 from consuldemocracy/dependab…

    …ot/bundler/factory_bot_rails-6.4.3
    
    Bump factory_bot_rails from 6.2.0 to 6.4.3
    javierm committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    a30917b View commit details
    Browse the repository at this point in the history
  7. Bump faker from 3.2.1 to 3.2.3

    Bumps [faker](https://github.com/faker-ruby/faker) from 3.2.1 to 3.2.3.
    - [Release notes](https://github.com/faker-ruby/faker/releases)
    - [Changelog](https://github.com/faker-ruby/faker/blob/main/CHANGELOG.md)
    - [Commits](faker-ruby/faker@v3.2.1...v3.2.3)
    
    ---
    updated-dependencies:
    - dependency-name: faker
      dependency-type: direct:development
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    518eb33 View commit details
    Browse the repository at this point in the history
  8. Merge pull request consuldemocracy#5373 from consuldemocracy/dependab…

    …ot/bundler/faker-3.2.3
    
    Bump faker from 3.2.1 to 3.2.3
    javierm committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    8ec1edc View commit details
    Browse the repository at this point in the history
  9. Bump pdf-reader from 2.11.0 to 2.12.0

    Bumps [pdf-reader](https://github.com/yob/pdf-reader) from 2.11.0 to 2.12.0.
    - [Changelog](https://github.com/yob/pdf-reader/blob/main/CHANGELOG)
    - [Commits](yob/pdf-reader@v2.11.0...v2.12.0)
    
    ---
    updated-dependencies:
    - dependency-name: pdf-reader
      dependency-type: direct:development
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] authored and javierm committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    ac9472c View commit details
    Browse the repository at this point in the history
  10. Merge pull request consuldemocracy#5361 from consuldemocracy/dependab…

    …ot/bundler/pdf-reader-2.12.0
    
    Bump pdf-reader from 2.11.0 to 2.12.0
    javierm committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    a6f3952 View commit details
    Browse the repository at this point in the history
  11. Bump bullet from 7.0.7 to 7.1.6

    Bumps [bullet](https://github.com/flyerhzm/bullet) from 7.0.7 to 7.1.6.
    - [Changelog](https://github.com/flyerhzm/bullet/blob/main/CHANGELOG.md)
    - [Commits](flyerhzm/bullet@7.0.7...7.1.6)
    
    ---
    updated-dependencies:
    - dependency-name: bullet
      dependency-type: direct:development
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    331784e View commit details
    Browse the repository at this point in the history
  12. Merge pull request consuldemocracy#5374 from consuldemocracy/dependab…

    …ot/bundler/bullet-7.1.6
    
    Bump bullet from 7.0.7 to 7.1.6
    javierm committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    8ac1acc View commit details
    Browse the repository at this point in the history
  13. Bump view_component from 3.6.0 to 3.11.0

    Bumps [view_component](https://github.com/viewcomponent/view_component) from 3.6.0 to 3.11.0.
    - [Release notes](https://github.com/viewcomponent/view_component/releases)
    - [Changelog](https://github.com/ViewComponent/view_component/blob/main/docs/CHANGELOG.md)
    - [Commits](ViewComponent/view_component@v3.6.0...v3.11.0)
    
    ---
    updated-dependencies:
    - dependency-name: view_component
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] authored and javierm committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    52ec509 View commit details
    Browse the repository at this point in the history
  14. Simplify using helper methods in components

    The `use_helpers` method was added in ViewComponent 3.8.0, and it's
    included by default in all components since version 3.11.0.
    
    Note we sometimes delegated the `can?` method to the controller instead
    of the helpers, for no particularly reason. We're unifying that code as
    well.
    javierm committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    1d955b7 View commit details
    Browse the repository at this point in the history
  15. Prevent Unable to autoload constant error in tests

    When running these tests, under certain conditions, we get a warning
    followed by an error:
    
    ```
    activesupport-6.1.7.7/lib/active_support/dependencies.rb:502:
    warning: already initialized constant ActiveStorage::Representations
    
    activesupport-6.1.7.7/lib/active_support/dependencies.rb:502:
    warning: previous definition of Representations was here
    
    Failure/Error: raise LoadError, "Unable to autoload constant
    '#{qualified_name}', expected #{file_path} to define it"
    
    LoadError: Unable to autoload constant
    ActiveStorage::Representations::RedirectController, expected
    activestorage-6.1.7.7/app/controllers/active_storage/representations/redirect_controller.rb
    to define it
    ```
    
    The error seems to take place when we request a page in a test that
    loads two (or more) ActiveStorage images if ActiveStorage hasn't loaded
    yet, although it's a flaky error and so the test doesn't always behave
    like this.
    
    We've tested that switching to zeitwerk solves the issue but, since we
    aren't switching to zeitwerk in version 2.1.1 and we'd like this version
    to run all tests correctly, for now we're changing the tests so they
    don't load two records with images.
    
    On of these tests ("Polls Index Polls can be listed") fails on my
    machine when run individually. I haven't been able to consistently
    reproduce the other ones.
    javierm committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    2af1fc7 View commit details
    Browse the repository at this point in the history
  16. Don't create records after a visit in polls tests

    Creating records after starting the browser with the `visit` method
    sometimes results in database corruption and failing tests on our CI.
    
    Splitting some tests or merging them together solves the issue.
    javierm committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    c480cdd View commit details
    Browse the repository at this point in the history
  17. Simplify creating a proposal poll in a test

    This way we avoid variables starting with underscores, which we don't
    use almost anywhere else.
    javierm committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    deb8b37 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2024

  1. Fix invalid HTML in comment votes

    We forgot to change the `span` tag when we replaced links with buttons
    in commit ba0d21b.
    javierm committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    a101608 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. Configuration menu
    Copy the full SHA
    8b3ec8f View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2024

  1. Add missing Spanish translations

    These texts were added in English in commit 7070b09, but we forgot to
    add the texts in Spanish as well.
    javierm committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    3d63238 View commit details
    Browse the repository at this point in the history
  2. Merge pull request consuldemocracy#5403 from consuldemocracy/missing_…

    …spanish_translations
    
    Add missing Spanish translations
    javierm committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    8006227 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. Merge pull request consuldemocracy#5399 from consuldemocracy/dependab…

    …ot/bundler/view_component-3.11.0
    
    Bump view_component from 3.6.0 to 3.11.0
    javierm committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    a670b77 View commit details
    Browse the repository at this point in the history
  2. Update Code Climate Rubocop version

    Code Climate was failing to analyze our repo because their rubocop 1.31
    doesn't support rubocop-capybara.
    
    Since we're using rubocop 1.56.4 in our code, we're going to use
    version 1.56.3 for Code Climate which, at the time of writing, is the
    latest available version in Code Climate.
    javierm committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    d921eee View commit details
    Browse the repository at this point in the history
  3. Merge pull request consuldemocracy#5426 from consuldemocracy/fix_comm…

    …ent_votes_html
    
    Fix invalid HTML in comment votes
    javierm committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    bbac39e View commit details
    Browse the repository at this point in the history
  4. Temporarily disable a test that fails sometimes

    This test is failing often due to an "Unable to autoload constant"
    error, that will be fixed after switching to zeitwerk.
    
    Just like it happened in the the "Polls can be listed" test, the reason
    seems to be accessing a page containing several ActiveStorage
    attachments. However, since this test only makes sense when two or more
    images are displayed on the page, we can't change the test so create
    just one image.
    
    So, for now, we're commenting the test, and we'll uncomment it again
    when we enable zeitwerk in version 2.2.0.
    javierm committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    8ba37b2 View commit details
    Browse the repository at this point in the history
  5. Merge pull request consuldemocracy#5431 from consuldemocracy/rubocop_…

    …capybara_code_climate
    
    Update Code Climate Rubocop version
    javierm committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    c7ea55a View commit details
    Browse the repository at this point in the history
  6. Merge pull request consuldemocracy#5422 from consuldemocracy/fix_poll…

    …s_test
    
    Prevent "Unable to autoload constant" error in tests
    javierm committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    0972bcb View commit details
    Browse the repository at this point in the history
  7. Fix link to debates help

    This link used to open in a new window, and we accidentally changed that
    behavior while refactoring it in commit c2710de.
    
    Since we're adding a test for this case, and the Proposals::NewComponent
    class is similar, we're adding a test for that class too. In the case of
    proposals, we need to sign in a user because the proposals form contains
    fields to attach image, that currently rely on a user being signed in.
    javierm committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    1a22db8 View commit details
    Browse the repository at this point in the history
  8. Merge pull request consuldemocracy#5395 from consuldemocracy/fix_new_…

    …window_typo
    
    Fix link to debates help
    javierm committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    0658edb View commit details
    Browse the repository at this point in the history
  9. Merge pull request consuldemocracy#5389 from CoslaDigital/render_geojson

    Allow whitespace between square brackets in GeoJSON polygons
    javierm committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    77505db View commit details
    Browse the repository at this point in the history
  10. Add Rails/DeprecatedActiveModelErrorsMethods rule

    Even though we're already applying this rule since commit 08b12a7,
    it's very useful to have it so we don't accidentally introduce code that
    won't work with Rails 7.
    
    After upgrading to Rails 7, this rule will no longer be necessary, since
    the code using the deprecated syntax will not work and so we'll notice
    it immediately.
    javierm committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    86cf674 View commit details
    Browse the repository at this point in the history
  11. Add and apply Rails/WhereMissing rubocop rule

    So now we know where to use the `where.missing` method which was
    introduced in Rails 6.1.
    
    Note this rule didn't detect all cases where the new method can be used.
    javierm committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    d0fae33 View commit details
    Browse the repository at this point in the history
  12. Merge pull request consuldemocracy#5421 from consuldemocracy/rails6.1…

    …_rubocop_rules
    
    Add rubocop rules affecting Rails 6.1
    javierm committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    42eff36 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. Sanitize the output of a dummy component class

    After commit 52ec509, we started to get a warning when running out
    test suite:
    
    ```
    WARNING: The #<Class:0x00007958c06fb8e0> component rendered HTML-unsafe
    output. The output will be automatically escaped, but you may want to
    investigate.
    ```
    
    The reason is that, for security reasons, since version 3.9.0,
    ViewComponent no longer renders unsafe output in the `call` method, so
    we need to make sure the rendered text is safe. This is similar to what
    Rails automatically does in views with `<%= %>`.
    
    While this change doesn't affect the application (this class is only
    used in a test), with it we avoid the warning.
    javierm committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    669472c View commit details
    Browse the repository at this point in the history
  2. Merge pull request consuldemocracy#5432 from consuldemocracy/fix_unsa…

    …fe_spec_warning
    
    Sanitize the output of a dummy component class
    javierm committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    31f42a2 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2024

  1. Release version 2.1.1

    javierm committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    b9e939d View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2024

  1. Merge pull request consuldemocracy#5428 from consuldemocracy/release_…

    …2.1.1
    
    Release version 2.1.1
    javierm committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    82c24a7 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2024

  1. Configuration menu
    Copy the full SHA
    2a6809b View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. Fix specs after upgrade

    microweb10 committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    9c37d0f View commit details
    Browse the repository at this point in the history