Group the common checks together #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of having the same rules copied for all devices, group the checks that we run on all of them anyway into a set of checks at the beginning. This way we can quickly filter out nonmatching devices. This also removes the ID_INPUT_JOYSTICK tag removal for js devices, the device should be matched by the preceding rule and thus have the property removed alrady. No real functional changes, but we now ignore remove events.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having the same rules copied for all devices, group the checks that
we run on all of them anyway into a set of checks at the beginning. This way
we can quickly filter out nonmatching devices.
This also removes the ID_INPUT_JOYSTICK tag removal for js devices, the device
should be matched by the preceding rule and thus have the property removed
alrady.
No real functional changes, but we now ignore remove events.