chol, qr, lq gradients #55
Conversation
| S = iL * Symmetric(L*dL',:L) * iL' | ||
| S/2 | ||
| end | ||
|
|
There was a problem hiding this comment.
@CarloLucibello let's not break the AutoGrad's regular testing pipeline. Could you pls. add
addtest(:chol, rand(3,3))- I think we need to find a way to write similar tests for qr and lq and remove them from the test/primitives.jl
There was a problem hiding this comment.
I'd like to keep tests this way. It is kind of atypical in the julia ecosystem to add tests into the src/ folder, and I don't want to scratch my head to figure out how to add tests for qr in the non-standard way while the easy way is also the standard way
|
@CarloLucibello AutoGrad is not like any regular package in the Julia ecosystem in that it touches and overloads hundreds of functions. I found keeping separate src / test files in sync impractical. The current method allows you to define a number of functions and their tests together in the same for loop. I am open to suggestions of improving the system, but I don't think doing the standard thing is a realistic suggestion. I will fix tests in this PR after merge. |
x-ref #45