refactor(cli): once_cell::sync::Lazy -> std::sync::LazyLock, once_cell::sync::OnceCell -> std::sync::OnceLock

[linbingquan]

refactor(cli): once_cell::sync::Lazy -> std::sync::LazyLock, once_cell::sync::OnceCell -> std::sync::OnceLock

link: https://blog.rust-lang.org/2024/07/25/Rust-1.80.0.html#lazycell-and-lazylock

[dsherret]

Why this change? lazy_regex evaluates the regex at compile time from my understanding and now we're no longer doing that.

[linbingquan]

Why this change? lazy_regex evaluates the regex at compile time from my understanding and now we're no longer doing that.

Because it has this error. Correct me if I am wrong.

error[E0308]: mismatched types
  --> cli\lsp\tsc.rs:98:20
   |
98 |   LazyLock::new(|| lazy_regex!(r#"^\[['"](.+)[\['"]\]$"#));
   |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `Regex`, found `Lazy<_, ...>`
   |
   = note: expected struct `regex::Regex`
              found struct `lazy_regex::Lazy<_, {closure@cli\lsp\tsc.rs:98:20: 98:58}>`
   = note: this error originates in the macro `lazy_regex` (in Nightly builds, run with -Z macro-backtrace for more info)

For more information about this error, try `rustc --explain E0308`.
error: could not compile `deno` (bin "deno") due to 1 previous error

[dsherret]

I think it can be changed to:

static BRACKET_ACCESSOR_RE: lazy_regex::Lazy<Regex> =
  lazy_regex!(r#"^\[['"](.+)[\['"]\]$"#);

[bartlomieju]

@linbingquan if you're still interested in landing this PR can you please rebase it and apply David's suggestion from #25104 (comment)?

[linbingquan]

@linbingquan if you're still interested in landing this PR can you please rebase it and apply David's suggestion from #25104 (comment)?

I saw a lot of code that needed to be cut before 2.0 was released, so I didn't do it.

To be honest, I upgraded the Rust 1.81.0 build after the 2.0 release and it failed...

Let me try again.

[bartlomieju]

Would it be possible to remove dependency on once_cell in various crates you changed? Ie. remove it from relevant Cargo.toml files.

[linbingquan]

Ie. remove it from relevant Cargo.toml files.

I have a quick look, should not be able to complete the deletion of 'once_cell', 'once_cell' is used elsewhere.

Would it be possible to remove dependency on once_cell in various crates you changed?

I'm sorry, I didn't know what you wanted me to do.

[linbingquan]

I now feel that this refactoring is not very necessary, I close this PR.