Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/console): more precision in console.time #25723

Merged
merged 3 commits into from
Sep 19, 2024
Merged

fix(ext/console): more precision in console.time #25723

merged 3 commits into from
Sep 19, 2024
+35 −3

Conversation

lucacasonato
Copy link
Member

@lucacasonato lucacasonato commented Sep 19, 2024 •
edited
Loading

Closes #15175

marvinhagemeister
marvinhagemeister approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a test would be nice if possible

@lucacasonato
Copy link
Member Author

@marvinhagemeister Test is difficult, because I can't assert anything really - due to slow CI the test may run longer than 1, 10, or even 100ms, so I can't assert the number of digits after the ..

@marvinhagemeister
Copy link
Contributor

fair point 👍

@lucacasonato lucacasonato merged commit 159ac45 into main Sep 19, 2024
17 checks passed
@lucacasonato lucacasonato deleted the console_time_precision branch September 19, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@crowlKats crowlKats crowlKats approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Different output in console.timeEnd between engines
3 participants
@lucacasonato @marvinhagemeister @crowlKats