Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ext/web): add [[ErrorData]] slot to DOMException #27342

Merged

Conversation

petamoriken
Copy link
Contributor

@petamoriken petamoriken commented Dec 12, 2024

Preparing for Stage 3 Error.isError (whatwg/webidl#1421)

Node.js util.isError already returns true for DOMException, so this change should have no effect.

@petamoriken
Copy link
Contributor Author

Oh, it appears that util.types.isNativeError is affected by this change.

@petamoriken petamoriken force-pushed the fix/error-data-slot-to-dom-exceptions branch from 496f909 to da357ae Compare December 12, 2024 16:58
@petamoriken petamoriken changed the title fix(ext/web): add [[ErrorData]] slot to DOMException feat(ext/web): add [[ErrorData]] slot to DOMException Dec 12, 2024
@petamoriken petamoriken force-pushed the fix/error-data-slot-to-dom-exceptions branch 3 times, most recently from dbed1e9 to fbc01b8 Compare December 13, 2024 03:47
@petamoriken petamoriken force-pushed the fix/error-data-slot-to-dom-exceptions branch from fbc01b8 to f07bb0b Compare December 13, 2024 03:49
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx

@lucacasonato lucacasonato merged commit bf888d9 into denoland:main Dec 13, 2024
17 checks passed
@petamoriken petamoriken deleted the fix/error-data-slot-to-dom-exceptions branch December 13, 2024 18:03
@ljharb ljharb mentioned this pull request Dec 13, 2024
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants