-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename op2 to op #808
base: main
Are you sure you want to change the base?
Rename op2 to op #808
Conversation
It has stayed op2 for a long time now with older op macro removed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #808 +/- ##
==========================================
+ Coverage 81.43% 81.75% +0.32%
==========================================
Files 97 98 +1
Lines 23877 24324 +447
==========================================
+ Hits 19445 19887 +442
- Misses 4432 4437 +5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.github/workflows/ci-test/action.yml: cargo run -p deno_core --example op2
.github/workflows/ci-test/action.yml: cargo run -p deno_core --example op2 --features include_js_files_for_snapshotting
core/examples/op2.rs: esm_entry_point = "ext:op_sample/op2.js",
core/examples/op2.rs: esm = [ dir "examples", "op2.js" ],
Can you update the following instances?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if CI is green
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a fan of renaming, but I guess that's okay
It has stayed op2 for a long time now with older op macro removed