Fix aliasing bugs revealed by Tree Borrows

[JoJoDeveloping]

This PR fixes some aliasing bugs caused by improper usage of shared and mutable references intermixed with raw pointer accesses. These have been discovered by running the testsuite under Tree Borrows, a new aliasing model for Rust and a potential replacement for Stacked Borrows. While TB is in general more lenient than SB, there are some cases where it is more strict due to SB relying on gross hacks, which have been removed from TB.

Turns out that deno_core relied on such hacks. The problem is with the DynFutureInfoErased, which has arbitrary data that is being modified by a future while other references to it are held in the runtime. To prevent this, that is put into an UnsafeCell which makes such modifications allowed.

But UnsafeCell only ensures that shared references can be modified without causing UB, it does not permit mutable references to be aliased. Thus, one should take care not to create mutable references here. The easiest way of doing this is to remove the implementation of DerefMut and AsMut for ArenaBox<T>, and work around the few cases where that leads to breakage (by using raw pointers, which is also more robust in terms of the aliasing model).

This fixes #884. See that issue for more information.

I have not audited the entire crate, so it is possible that other TB bugs are lurking elsewhere; especially in the parts that Miri can currently not test properly. But this at least makes all the test that could work, do work.

[CLAassistant]

All committers have signed the CLA.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.91%. Comparing base (0c7f83e) to head (3f60789).
Report is 113 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #889      +/-   ##
==========================================
+ Coverage   81.43%   81.91%   +0.47%     
==========================================
  Files          97       98       +1     
  Lines       23877    24928    +1051     
==========================================
+ Hits        19445    20419     +974     
- Misses       4432     4509      +77     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[devsnek]

i don't have any context on this code specifically but the overall changes seem good for an arena-shaped api