Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add -g flag for global system install #284

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add -g flag for global system install #284

wants to merge 6 commits into from

Conversation

Mqxx
Copy link

@Mqxx Mqxx commented May 28, 2024 •
edited
Loading

This pull request adds a flag to the install script for the global installation of Deno. If the flag is set the global system PATH variable for Deno is set instead of the user PATH variable and the default installation directory is set to ${Env:ProgramFiles}\deno\bin instead of ${Home}\.deno\bin variable.

@Mqxx Mqxx mentioned this pull request Jun 11, 2024
Open
dsherret
dsherret reviewed Jun 11, 2024
View reviewed changes
install_global.ps1 Outdated Show resolved Hide resolved
@dsherret
Copy link
Member

@joaka1987 can you please stop spamming?

@Mqxx
Added flag for global install
898fd90 
Removed old install_global.ps1 script
@Mqxx Mqxx requested a review from dsherret July 1, 2024 05:56
@Mqxx Mqxx changed the title Add install_global.ps1 for global system install Add -g flag for global system install Jul 1, 2024
@Mqxx
Copy link
Author

Mqxx commented Jul 8, 2024

Hey @dsherret, can this be merged?

dsherret
dsherret requested changes Jul 8, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Almost there.

install.ps1 Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
install.ps1 Outdated Show resolved Hide resolved
@Mqxx
Copy link
Author

Mqxx commented Jul 8, 2024

I will make these changes asap.

@Mqxx
Review
1ed286e 
- Switched elseif
- Changed `g` to `denoGlobalInstall` flag
- Moved description to the bottom
@Mqxx
Copy link
Author

Mqxx commented Jul 8, 2024

@dsherret Done 👍

@dsherret
Copy link
Member

dsherret commented Jul 8, 2024

Hmmm... not sure why the mac ci is failing. Must be unrelated.

@Mqxx
Copy link
Author

Mqxx commented Jul 15, 2024

Hey @dsherret, can you re-run it?

@Mqxx
Copy link
Author

Mqxx commented Jul 19, 2024

@dsherret can this be merged?

@Mqxx
Copy link
Author

Mqxx commented Aug 1, 2024

For some reason the pipeline fails. I am not sure why.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mqxx @dsherret