fix(http): have getCookies() return Record<string, string | undefined>
#5996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the return type Record<string, string | undefined> so that TypeScript will force you to check that the cookie is actually present. Fixes denoland#5979
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5996 +/- ##
=======================================
Coverage 96.29% 96.29%
=======================================
Files 493 493
Lines 39530 39531 +1
Branches 5833 5834 +1
=======================================
+ Hits 38065 38066 +1
Misses 1423 1423
Partials 42 42 ☔ View full report in Codecov by Sentry. |
iuioiua
changed the title
getCookies() return Record<string, string | undefined>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the return type of
getCookiesRecord<string, string | undefined>so that TypeScript will force you to check that the cookie is actually present before using it.Note that this is not a breaking code change, but it is a breaking type change, i.e. code that used to type check successfully may not anymore after updating to a version that includes this change.
Fixes #5979