Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: type check errors from outdated declarations #151

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/driver/mysql/MysqlQueryRunner.ts
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ export class MysqlQueryRunner extends BaseQueryRunner implements QueryRunner {
*/
protected databaseConnectionPromise!: Promise<[Connection, () => Promise<void>]>;

protected databaseConnection!: [Connection, () => Promise<void>];
declare protected databaseConnection: [Connection, () => Promise<void>];

// -------------------------------------------------------------------------
// Constructor
Expand Down
2 changes: 1 addition & 1 deletion src/driver/postgres/PostgresQueryRunner.ts
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export class PostgresQueryRunner extends BaseQueryRunner implements QueryRunner
*/
protected releaseCallback!: () => Promise<void>;

protected databaseConnection!: PoolClient;
declare protected databaseConnection: PoolClient;

// -------------------------------------------------------------------------
// Constructor
Expand Down
4 changes: 2 additions & 2 deletions src/driver/sqlite/SqliteDriver.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@ export class SqliteDriver extends AbstractSqliteDriver {
*/
options: SqliteConnectionOptions;

databaseConnection!: DB;
declare databaseConnection: DB;

sqlite!: DenoSqlite;
declare sqlite: DenoSqlite;


// -------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion src/driver/sqljs/SqljsDriver.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ declare var window: Window;

export class SqljsDriver extends AbstractSqliteDriver implements AutoSavableDriver {
// The driver specific options.
options!: SqljsConnectionOptions;
declare options: SqljsConnectionOptions;

// -------------------------------------------------------------------------
// Constructor
Expand Down
2 changes: 1 addition & 1 deletion src/repository/MongoRepository.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export class MongoRepository<Entity extends ObjectLiteral> extends Repository<En
/**
* Entity Manager used by this repository.
*/
readonly manager!: MongoEntityManager;
declare readonly manager: MongoEntityManager;

// -------------------------------------------------------------------------
// Overridden Methods
Expand Down