Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use assert for type assertion for all.json #15

Closed
wants to merge 1 commit into from

Conversation

ycmjason
Copy link

@ycmjason ycmjason commented Sep 8, 2024

No description provided.

@eliassjogreen
Copy link
Member

Import assertions use the with keyword since a little while back (see https://github.com/tc39/proposal-import-attributes). If the current version doesn't work I suggest either updating deno/your runtime of choice or using an older version of this module :)

@ycmjason
Copy link
Author

ycmjason commented Sep 8, 2024

@eliassjogreen

I didn't notice that I am on [email protected] and there assert is used in there for type assertion. That causes Deno to warn:

⚠️ Import assertions are deprecated. Use with keyword, instead of 'assert' keyword.

And I just mindlessly came to this repo and switch assert to with or vice versa. 😂

Anyways..... thank you so much for pointing out!

I notice 0.3.0 is the latest published version?

Any plans on publishing the code in main so I can get the version of emoji using with for type assertion?

@eliassjogreen
Copy link
Member

Aha! Thats probably because we haven't released an update to the X registry? I know the version published to JSR is up to date if you can use that. Otherwise i'll look into releasing a new X version too.

@ycmjason
Copy link
Author

ycmjason commented Sep 8, 2024

Aha! Thats probably because we haven't released an update to the X registry? I know the version published to JSR is up to date if you can use that. Otherwise i'll look into releasing a new X version too.

Ah yes! (Honestly, I still haven't found out which dependency in my code uses emoji hahahahhaha, so I'll need to dig into that and try to have it using JSR for now!)

@ycmjason
Copy link
Author

ycmjason commented Sep 8, 2024

Thanks for the great work too @eliassjogreen ❤️

@eliassjogreen
Copy link
Member

eliassjogreen commented Sep 9, 2024

@ycmjason I made a 0.3.1 release for deno.land/x btw :)

@ycmjason ycmjason deleted the patch-1 branch September 9, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants