Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[as4224/as5114/as4564] Update DTS #154

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

brandonchuang
Copy link
Contributor

In order to upgrade the LK release from 5.10.4 to 5.10.7x the addition modification shown below is mandatory.
dma-ranges = <0x42000000 0x0 0x00000000 0x0 0x00000000 0x0 0x40000000>;

The SSD parameter has been adjusted to have better performance in uboot
So the linux kernel does not need to initialize the default value
By this skip phy config then it can leverage the adjusted parameter of uboot.

Signed-off-by: Brandon Chuang [email protected]

@brandonchuang brandonchuang changed the title [as4224/as5114/as4564] Update DTS. [as4224/as5114/as4564] Update DTS Nov 25, 2021
Copy link
Contributor

@paulmenzel paulmenzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to upgrade the LK release from 5.10.4 to 5.10.7x the addition modification shown below is mandatory.
dma-ranges = <0x42000000 0x0 0x00000000 0x0 0x00000000 0x0 0x40000000>;

What Linux kernel commit makes that mandatory?

The SSD parameter has been adjusted to have better performance in uboot

Please make that a separate commit (part of the merge/pull request) with an elaborate description of the problem and how the performance was measured/tested.

So the linux kernel does not need to initialize the default value

You start with a capital letter. Is that a new sentence? If not, what do you refer to (still SSD)?

By this skip phy config then it can leverage the adjusted parameter of uboot.

Please rephrase. I do not understand what you mean.

Mickey201
Mickey201 previously approved these changes Feb 2, 2022
In order to upgrade the LK release from 5.10.4 to 5.10.7x the addition modification shown below is mandatory.
dma-ranges = <0x42000000 0x0 0x00000000 0x0 0x00000000 0x0 0x40000000>;

The SSD parameter has been adjusted to have better performance in uboot
So the linux kernel does not need to initialize the default value
By this skip phy config then it can leverage the adjusted parameter of uboot.

Signed-off-by: Brandon Chuang <[email protected]>
@Mickey201
Copy link
Contributor

@sonoble, not clear to me which commit isn't signed yet in this PR?

@sonoble
Copy link
Contributor

sonoble commented Feb 10, 2022

I don't think we need this commit as we are not moving to 5.10.7x. Let me know if I am wrong. I need to look deeper into the unsigned commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants