LEAF 4629 ifthen checking optimizations #2647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update regex. Update commnets for better clarity. Update selector for chaining so that only one check is run for radio/checkboxes, and only chain if also a controller. Skip clear if hidden class. Troubleshooting validation toggle
Simplify value clearing loop. Add break to multioption value checking in case multiple conditions are used (rare). Remove a reduntant check for radio format indicators.
aerinkayne
requested review from
mgaoVA,
pete-nerantzinis,
Pelentan,
shaneodd,
jampaul3 and
nk2136
shaneodd
previously approved these changes
Jan 13, 2025
jampaul3
previously approved these changes
Jan 14, 2025
Pelentan
requested changes
Jan 17, 2025
| }); | ||
| //grids cannot be controllers so we do not need to worry about them having input for the final check below | ||
| $(`#grid_${id}_1_input tbody td`) //grid table data | ||
| .each(function () { |
There was a problem hiding this comment.
Does this need a final "else"? What happens if none of these conditions are met?
Pelentan
previously approved these changes
Jan 21, 2025
Pelentan
added
the
With QA
aerinkayne
dismissed stale reviews from Pelentan, jampaul3, and shaneodd
via
212f698
jampaul3
approved these changes
Jan 22, 2025
Pelentan
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Front end only.
Modify chain trigger to only target one checkbox/radio, and only for indicators that are also controllers.
This fixes an issue where condition checking could occur more times than intended for these formats, causing considerable slowdown for forms with a large number (eg 100+) of conditional indicators.
Fix an uncovered issue that prevented file loaded dropdowns from loading on internal forms
(form fields might have initially been tested with the same form)
Fix an issue that could cause cleared controlled questions to temporarily display if an indirect parent ancestor value was toggled (The questions would hide if needed when user interacted with the direct parent, so it was more of a display issue)
General optimization: Simplify frontend required validation toggling. Consolidate loops in value clearing. Reorganize code, add / reword comments for further clarity
Impact / Testing
Request data entry areas for forms containing ifthen logic.
Potential impact is high - Events and required validation swapping need to be correct to allow form progress.
Setup
See the corresponding Jira story (LEAF-4629) docs for
-A form associated with this issue
-A csv file with dropdown options for testing loaded dropdowns
Add the 'animal categories' CSV file from the Jira story to the portal file manager.
Import the form packet from the Jira story in the Form Editor.
Set a workflow (recommend wf 1) and update the form's status to 'available'.
In the workflow, set a step form field to this form's 'local item' internal (recommend wf 1 step 2 since it has a 'note' action).
Create a new request for the form and submit it.
Move the form to the workflow step that has the form field.
Test the data entry process and confirm that