Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VA-15057] VAMC System Banner Alert inline editor FE Review #1738

Closed
wants to merge 2 commits into from

Conversation

maxx1128
Copy link
Contributor

@maxx1128 maxx1128 commented Oct 6, 2023

DO NOT MERGE until PM review is done & work authorized to move forward, and CMS work is complete.

Description

This pull request changes the VAMC System Banner alert to make way for changes in the CMS, as per Swirt's recommendations in this comment.

relates to #15057

Testing done & Screenshots

Local tests pass and build is successful

Confirmation that the update query returns the same data. The front-end template was updated to reflect the new data structure.

Screen Shot 2023-10-10 at 10 44 18 AM

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

  1. Confirm that the build is still successful with the changes
    • Validate that the src/site/stages/build/drupal/graphql/vamcOperatingStatusAndAlerts.graphql.js query still builds properly
    • Check that the two affected front-end template files are updated with the new entity data structure.\

Acceptance criteria

  • QA criteria has passed.

Definition of done

  • Events are logged appropriately
  • Documentation has been updated, if applicable
  • A link has been provided to the originating GitHub issue (or connected to it via ZenHub)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs

Copy link
Contributor

@chriskim2311 chriskim2311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

github-actions bot commented Feb 8, 2024

This PR is stale because it has been open 120 days with no activity. It will receive a stale label every day for 14 days before being closed unless it receives a comment or the stale label is removed.

@github-actions github-actions bot added the Stale label Feb 8, 2024
@github-actions github-actions bot closed this Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants