Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-15641: Adds 'add to National Outreach Calendar' checkbox #1752

Merged
merged 4 commits into from
Oct 26, 2023

Conversation

dsasser
Copy link
Contributor

@dsasser dsasser commented Oct 19, 2023

Relates to:
department-of-veterans-affairs/va.gov-cms#15856
department-of-veterans-affairs/va.gov-cms#15641

Description

In department-of-veterans-affairs/va.gov-cms#15761 we are adding a new field to the CMS to support adding an Event to multiple Event Listings, without changing the cardinality of field_listing to unlimited.

This PR adds the additional field query to the existing Event List GraphQl query, and assembles the data together before handing off to the event listing, providing the related feature toggle is enabled.

Relates to:
department-of-veterans-affairs/va.gov-cms#15641

Testing done & Screenshots

Jill and Laura tested this end-to-end along with the CMS changes in Tugboat.

QA steps

Use this Tugboat instance for QA testing: https://web-hslpokhhcwuf19pbvpxpq3ppmlpldumq.demo.cms.va.gov/

  1. Visit /outreach-and-events/outreach-materials/
    • Verify publications are rendering/present
  2. Visit /alaska-health-care/stories/learn-how-to-cook-with-healthy-teaching-kitchen
    • Verify the 'See all stories' link is present and points to the correct location.
  3. Visit /lovell-federal-health-care-va/events/
    • Verify events have correct and functioning URLs for both types of pages (tricare && beneficiary)

Acceptance criteria

  • Tests are passing
  • Outreach Materials page displays publications
  • VAMC Stories (example) -- "See all stories" link is present at the foot of the page.
  • Lovell events are not affected

… event_listing query;

- Merges event data from both event_listing reverse queries.
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/VACMS-15641-events-outreach-cal-field-listing-updates October 19, 2023 23:15 Inactive
@dsasser dsasser changed the title VACMS-15641: Adds new CMS field 'fieldAdditionalListings' to existing… VACMS-15641: Adds 'add to National Outreach Calendar' checkbox Oct 23, 2023
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/VACMS-15641-events-outreach-cal-field-listing-updates October 23, 2023 17:00 Inactive
@dsasser dsasser marked this pull request as ready for review October 23, 2023 17:24
@dsasser dsasser requested review from a team as code owners October 23, 2023 17:24
@dsasser dsasser marked this pull request as draft October 23, 2023 20:03
@dsasser dsasser changed the title VACMS-15641: Adds 'add to National Outreach Calendar' checkbox DO NOT MERGE: VACMS-15641: Adds 'add to National Outreach Calendar' checkbox Oct 24, 2023
@dsasser dsasser changed the title DO NOT MERGE: VACMS-15641: Adds 'add to National Outreach Calendar' checkbox VACMS-15641: Adds 'add to National Outreach Calendar' checkbox Oct 26, 2023
@dsasser dsasser marked this pull request as ready for review October 26, 2023 17:43
Copy link
Contributor

@chriskim2311 chriskim2311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, tested in tugboat env everything looks good on my end

@dsasser dsasser merged commit 84e2eca into main Oct 26, 2023
24 checks passed
@dsasser dsasser deleted the VACMS-15641-events-outreach-cal-field-listing-updates branch October 26, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants