-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VACMS-15641: Adds 'add to National Outreach Calendar' checkbox #1752
Merged
dsasser
merged 4 commits into
main
from
VACMS-15641-events-outreach-cal-field-listing-updates
Oct 26, 2023
Merged
VACMS-15641: Adds 'add to National Outreach Calendar' checkbox #1752
dsasser
merged 4 commits into
main
from
VACMS-15641-events-outreach-cal-field-listing-updates
Oct 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… event_listing query; - Merges event data from both event_listing reverse queries.
…treach-cal-field-listing-updates
va-vfs-bot
temporarily deployed
to
master/main/VACMS-15641-events-outreach-cal-field-listing-updates
October 19, 2023 23:15
Inactive
14 tasks
dsasser
changed the title
VACMS-15641: Adds new CMS field 'fieldAdditionalListings' to existing…
VACMS-15641: Adds 'add to National Outreach Calendar' checkbox
Oct 23, 2023
va-vfs-bot
temporarily deployed
to
master/main/VACMS-15641-events-outreach-cal-field-listing-updates
October 23, 2023 17:00
Inactive
dsasser
changed the title
VACMS-15641: Adds 'add to National Outreach Calendar' checkbox
DO NOT MERGE: VACMS-15641: Adds 'add to National Outreach Calendar' checkbox
Oct 24, 2023
Closed
7 tasks
…treach-cal-field-listing-updates
dsasser
changed the title
DO NOT MERGE: VACMS-15641: Adds 'add to National Outreach Calendar' checkbox
VACMS-15641: Adds 'add to National Outreach Calendar' checkbox
Oct 26, 2023
ryguyk
approved these changes
Oct 26, 2023
chriskim2311
approved these changes
Oct 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, tested in tugboat env everything looks good on my end
dsasser
deleted the
VACMS-15641-events-outreach-cal-field-listing-updates
branch
October 26, 2023 21:11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to:
department-of-veterans-affairs/va.gov-cms#15856
department-of-veterans-affairs/va.gov-cms#15641
Description
In department-of-veterans-affairs/va.gov-cms#15761 we are adding a new field to the CMS to support adding an Event to multiple Event Listings, without changing the cardinality of field_listing to unlimited.
This PR adds the additional field query to the existing Event List GraphQl query, and assembles the data together before handing off to the event listing, providing the related feature toggle is enabled.
Relates to:
department-of-veterans-affairs/va.gov-cms#15641
Testing done & Screenshots
Jill and Laura tested this end-to-end along with the CMS changes in Tugboat.
QA steps
Use this Tugboat instance for QA testing: https://web-hslpokhhcwuf19pbvpxpq3ppmlpldumq.demo.cms.va.gov/
Acceptance criteria