Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove noreferrer #1768

Merged
merged 1 commit into from
Nov 1, 2023
Merged

remove noreferrer #1768

merged 1 commit into from
Nov 1, 2023

Conversation

eselkin
Copy link
Contributor

@eselkin eselkin commented Oct 30, 2023 •
edited
Loading

Description

relates to department-of-veterans-affairs/va.gov-cms#11848

Testing done & Screenshots

current (with noreferrer):
Screenshot 2023-10-30 at 3 32 34 PM

new (without noreferrer):
Screenshot 2023-10-30 at 3 36 54 PM

QA steps

  1. Do this go to: http://f22710de9318b08e12f9f2a74848a690.review.vetsgov-internal/sheridan-health-care
    • Validate that VA Sheridan health care operating status link does not have attribute rel=noreferrer

Acceptance criteria

  • VA Operating status link does not have rel=noreferrer attribute

Definition of done

  • Events are logged appropriately
  • Documentation has been updated, if applicable
  • A link has been provided to the originating GitHub issue (or connected to it via ZenHub)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs

laflannery
laflannery approved these changes Oct 31, 2023
View reviewed changes
Copy link

@laflannery laflannery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@eselkin eselkin marked this pull request as ready for review November 1, 2023 00:17
@eselkin eselkin merged commit ea9c805 into main Nov 1, 2023
24 checks passed
@eselkin eselkin deleted the VACMS-11848-remove-noreferrer-from-VA-link branch November 1, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laflannery laflannery laflannery approved these changes

@maxx1128 maxx1128 maxx1128 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eselkin @maxx1128 @laflannery