Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issue with breadcrumb URL #1781

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Conversation

jerekshoe
Copy link
Contributor

@jerekshoe jerekshoe commented Nov 6, 2023

Summary

In a previous PR (listed below) I update the URL for the current entry for the rated-disabilities application. I forgot to make sure that the breadcrumb URLs were update to match the change. This PR fixes that

Related PR(s)

Related issue(s)

What areas of the site does it impact?

Rated Disabilities Application

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

⚠️ Team Sites (only applies to modifications made to the VA.gov header) ⚠️

  • The header does not contain any web-components
  • I used the proxy-rewrite steps to test the injected header scenario
  • I reached out in the #sitewide-public-websites Slack channel for questions

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@Mottie
Copy link
Contributor

Mottie commented Nov 8, 2023

Have you looked into adding a redirect in the devops folder?

@jerekshoe
Copy link
Contributor Author

Have you looked into adding a redirect in the devops folder?

The URL hasn’t actually changed, I was just told to create a new entry with a dummy URL and then swap the real and dummy URLs when everything was confirmed to be working. I just forgot to swap to the real URL here. The dummy URL was never linked to or anything so it can just be removed

@jerekshoe jerekshoe merged commit b7e85c8 into main Nov 8, 2023
24 checks passed
@jerekshoe jerekshoe deleted the 66061-isolate-rated-disabilities-6 branch November 8, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants