Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-16036: Downgrade node-libcurl to v2.3.4 #1784

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

olivereri
Copy link
Contributor

Closes department-of-veterans-affairs/va.gov-cms#16036 . Will give time to upgrade Review Instances and CMS Staging servers to the right GCC version level to accommodate this package.

Discussion here:
https://dsva.slack.com/archives/CJT90C0UT/p1699300432617899

CMS tests of Content-build fail on Staging servers with:
image

@olivereri olivereri requested review from a team as code owners November 7, 2023 18:57
@tjheffner
Copy link
Contributor

tjheffner commented Nov 7, 2023

@olivereri the change looks fine, but you may need to regen the yarn.lock as well

yarn.lock still shows:

node-libcurl@^3.0.0:
  version "3.0.0"
  resolved "https://registry.yarnpkg.com/node-libcurl/-/node-libcurl-3.0.0.tgz#426014190d54fdacfd164b926c85d4f2d419c9d2"
  integrity sha512-wqIXXsHyOdBg5kZH02OgG1ZiunJumDdMyNXKul9I0AVEZLLMq2/SuOk1/8uvYiJ5y3+SGNBZYnS86keD8+Qo0Q==
  dependencies:
    "@mapbox/node-pre-gyp" "1.0.10"
    env-paths "2.2.0"
    nan "2.17.0"
    node-gyp "9.3.0"
    npmlog "6.0.2"
    rimraf "3.0.2"
    tslib "2.4.0"

Copy link
Contributor

@eselkin eselkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@olivereri olivereri merged commit 8600ccb into main Nov 7, 2023
21 checks passed
@olivereri olivereri deleted the VACMS-16036-Downgrade-node-libcurl-to-v2-3-4 branch November 7, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Content-Build adds Node-libcurl to Package.json Breaks Downstream CMS Staging Tests
4 participants