Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update both axe dependencies to latest #1786

Merged
merged 2 commits into from
Nov 9, 2023
Merged

update both axe dependencies to latest #1786

merged 2 commits into from
Nov 9, 2023

Conversation

pjhill
Copy link
Contributor

@pjhill pjhill commented Nov 8, 2023

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Summary

  • Platform reliability team is updating axe-related modules to the latest versions.
  • It looks like the a11y scan is currently off, so the impact to this repository should be minimal. Once the scan is turned back on, it may cause more failures than the previous versions as the scan is now more robust.

Related issue(s)

Testing done

  • Tested by starting up the site with a yarn watch locally and poked around the site a bit. I'm not expecting axe modules to affect site functionality. Unit tests and Cypress tests passed locally and in CI which is what we DO expect this update to affect.

Screenshots

N/A

What areas of the site does it impact?

CI pipeline

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated -- Daily accessibility scan for VA.gov static content
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

⚠️ Team Sites (only applies to modifications made to the VA.gov header) ⚠️

  • The header does not contain any web-components
  • I used the proxy-rewrite steps to test the injected header scenario
  • I reached out in the #sitewide-public-websites Slack channel for questions

Requested Feedback

None

@va-vfs-bot va-vfs-bot temporarily deployed to master/main/68729-update-cb-axe November 8, 2023 16:38 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/68729-update-cb-axe November 8, 2023 19:00 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/68729-update-cb-axe November 8, 2023 20:22 Inactive
@pjhill pjhill marked this pull request as ready for review November 9, 2023 15:18
@pjhill pjhill requested review from a team as code owners November 9, 2023 15:18
Copy link
Contributor

@ndouglas ndouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@pjhill pjhill merged commit 7e2192b into main Nov 9, 2023
24 checks passed
@pjhill pjhill deleted the 68729-update-cb-axe branch November 9, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants