15632 CLP Aspect Ratio update #1791
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vfs-bot
temporarily deployed
to
master/main/15632-clp-aspect-ratio
randimays
force-pushed
the
15632-clp-aspect-ratio
branch
from
95fc0fa to
a636f85
Compare
va-vfs-bot
temporarily deployed
to
master/main/15632-clp-aspect-ratio
randimays
force-pushed
the
15632-clp-aspect-ratio
branch
from
a636f85 to
40f115f
Compare
va-vfs-bot
temporarily deployed
to
master/main/15632-clp-aspect-ratio
randimays
force-pushed
the
15632-clp-aspect-ratio
branch
2 times, most recently
from
9e01f6b to
9b40e2a
Compare
va-vfs-bot
temporarily deployed
to
master/main/15632-clp-aspect-ratio
11 tasks
ndouglas
approved these changes
Nov 14, 2023
powellkerry
approved these changes
Nov 14, 2023
randimays
force-pushed
the
15632-clp-aspect-ratio
branch
from
9b40e2a to
b9eb59d
Compare
va-vfs-bot
temporarily deployed
to
master/main/15632-clp-aspect-ratio
randimays
force-pushed
the
15632-clp-aspect-ratio
branch
from
b9eb59d to
e2934a7
Compare
va-vfs-bot
temporarily deployed
to
master/main/15632-clp-aspect-ratio
|
Closing due to coding sync issues with Tugboat. Will open another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Campaign Landing Pages currently use a 7:2 aspect ratio that causes problems for rendering the image at various breakpoints.
Current design:
Design put together a new 1:1 design for Campaign Landing Pages so the text and the image would be side by side.
New design:
Related issue(s)
Testing done
Tested local build on:
Screenshots
Acceptance criteria