Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VA-15956: Add VBA facility service region facilities with taxonomies #1803

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

maxx1128
Copy link
Contributor

@maxx1128 maxx1128 commented Nov 20, 2023

Summary

VBA Regional Facilities can have several facilities connected with them as being within their region or "regional subsections." Each subsection also has several taxonomies associated with them to describe better and organize them for users.

This pull request adds the subsections with their taxonomies to the regional facility query. They can then be added to the VBA Regional Facility page.

Related issue(s)

Relates to #15956.

Testing done

I confirmed the working query in GraphQL Explorer and local build. Please take a look at the local page and the data in the web browser console below.

Screen Shot 2023-11-20 at 11 38 35 PM

Acceptance criteria

Quality Assurance & Testing

To confirm the data yourself:

  1. Pull this branch onto content-build and run yarn build --pull-drupal --drupal-address=https://cms-txcrk8bym4a0ivw3xfr8xvdhezmls36f.demo.cms.va.gov/ [email protected] password=drupal8.
  2. Run yarn serve for the local site and visit http://localhost:3002/cleveland-va-regional-benefit-office/locations/cleveland-va-regional-benefit-office/.
  3. In the page data in the web browser console, confirm that the data in the above image for reverseFieldVbaRegionFacilityListNode matches what's in your browser.

@va-vfs-bot va-vfs-bot temporarily deployed to master/main/va-15956-vba-regional-subsections-query November 20, 2023 17:00 Inactive
@maxx1128 maxx1128 force-pushed the va-15956-vba-regional-subsections-query branch from 4203be5 to a8ff63a Compare November 21, 2023 03:29
@maxx1128 maxx1128 changed the base branch from main to va-14940-vba-facility-content-skeleton November 21, 2023 03:32
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/va-15956-vba-regional-subsections-query November 21, 2023 03:33 Inactive
@maxx1128 maxx1128 marked this pull request as ready for review November 21, 2023 04:41
@maxx1128 maxx1128 requested review from a team as code owners November 21, 2023 04:41
@maxx1128 maxx1128 requested a review from eselkin November 21, 2023 16:03
Copy link
Contributor

@eselkin eselkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me. Do we want to ask @swirtSJW to double check?

Copy link
Contributor

@chriskim2311 chriskim2311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from va-14940-vba-facility-content-skeleton to main November 27, 2023 16:50
@jilladams jilladams requested a review from a team as a code owner November 27, 2023 16:50
@maxx1128 maxx1128 force-pushed the va-15956-vba-regional-subsections-query branch from a8ff63a to e111379 Compare November 27, 2023 18:47
@maxx1128 maxx1128 merged commit cf92386 into main Nov 28, 2023
21 checks passed
@maxx1128 maxx1128 deleted the va-15956-vba-regional-subsections-query branch November 28, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants