VACMS-10176: Fix Featured events when no featured event is live on Health Care Region Pages #1811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vfs-bot
temporarily deployed
to
master/main/10176-fix-featured-event
chriskim2311
changed the title
chriskim2311
changed the title
va-vfs-bot
temporarily deployed
to
master/main/10176-fix-featured-event
va-vfs-bot
temporarily deployed
to
master/main/10176-fix-featured-event
va-vfs-bot
temporarily deployed
to
master/main/10176-fix-featured-event
added 2 commits
November 29, 2023 22:14
va-vfs-bot
temporarily deployed
to
master/main/10176-fix-featured-event
randimays
dismissed
their stale review
Approved before noticing an issue with Featured events
randimays
approved these changes
Nov 30, 2023
chriskim2311
changed the title
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Pulled filter logic from graphQL to the browser in drupal liquid filters. Now there is a
filterAndSortEventsthat we will use to take in all events for a health care region(up to 1000 events) and filter then sort the events based on most upcoming event.Related issue(s)
department-of-veterans-affairs/va.gov-cms#10716
Testing done
Tested in tugboat env to check for event staleness. Was able to see all events are being passed through to the FE, not just 10 and most upcoming event is being shown.