Vacms 16208 police testing

[eselkin]

Summary

• Added unit testing to verify conversion of CSV data to JSON per expected format
• Sitewide Facilities

Related issue(s)

• Front End: Unit test coverage for VA Police data va.gov-cms#16208

Testing done

• Adds testing for expected format of CSV (requested from Axon)
• Adds unit test with missing files (missing contacts data)
• Adds unit test with present data and expects conversion
• Adds mock data in CSV format expected from Axon.

Screenshots

No UI changes

What areas of the site does it impact?

Solely unit testing is added.

Acceptance criteria

unit tests pass

Quality Assurance & Testing

• I added unit tests for conversion of expected Axon CSV data.
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Linting warnings have been addressed
• Documentation has been updated (not necessary)
• Screenshot of the developed feature is added (no screenshot)
• Accessibility testing has been performed

Error Handling

• Browser console contains no warnings or errors.
• Events are being sent to the appropriate logging solution
• Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

• Did you login to a local build and verify all authenticated routes work as expected with a test user (no changes for any path)

Requested Feedback

Check that tests pass.

[va-vfs-bot]

ESLint is disabled

vets-website uses ESLint to help enforce code quality. In most situations we would like ESLint to remain enabled.

What you can do

See if the code can be refactored to avoid disabling ESLint, or wait for a VSP review.

[eselkin]

The test curl client doesn't actually log in anywhere, so even if this email is eventually defunct at some point, this test will still pass.

[jilladams]

@eselkin this PR auto-tagged Public Websites front end, but not Facilities front-end. Could you add a rule to content-build codeowners file that makes Facilities the point of contact for the Police path? That can go into this PR, or a separate one, whatever is easier.

[eselkin]

@jilladams It doesn't want to seem to catch that directory. Already we should be requested because we changed src/site/stages/build/drupal since the vaPoliceData directory is under there and we are not requested. I added it to be specific but GitHub doesn't request the review.