Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VA Police Query and Page Skeleton #1825

Merged
merged 13 commits into from
Dec 19, 2023

Conversation

eselkin
Copy link
Contributor

@eselkin eselkin commented Dec 6, 2023

Summary

  • Creates Query for NodeVamcSystemVaPolice
  • Creates Page skeleton for VA Police
  • Sitewide Facilities
  • No flipper

Related issue(s)

Testing done

Screenshots

Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).

Before After
Mobile N/A screencapture-web-awcav66wmql5kqfvmoju7kxxfbvx6ivg-demo-cms-va-gov-maine-health-care-va-police-2023-12-16-13_18_35
Desktop N/A screencapture-web-awcav66wmql5kqfvmoju7kxxfbvx6ivg-demo-cms-va-gov-maine-health-care-va-police-2023-12-16-13_18_13

What areas of the site does it impact?

(Describe what parts of the site are impacted if code touched other areas)

Acceptance criteria

  • Add graphQL query for vamc_system_va_police content type.
  • Add page build step to content-build.
  • Add page level template (not including the React Ap)
  • Requires design review
  • Requires accessibility review

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

View page: https://web-awcav66wmql5kqfvmoju7kxxfbvx6ivg.demo.cms.va.gov/maine-health-care/va-police/
Compare with MMVP criteria in Sketch (not including data section)

  • Title
  • Intro text
  • Featured content police report
  • Contact
  • FAQ
  • No last updated date

@va-vfs-bot va-vfs-bot temporarily deployed to master/main/VACMS-16278-VA-Police-Query-And-Template December 6, 2023 18:03 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/VACMS-16278-VA-Police-Query-And-Template December 12, 2023 01:20 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/VACMS-16278-VA-Police-Query-And-Template December 13, 2023 00:04 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/VACMS-16278-VA-Police-Query-And-Template December 13, 2023 04:14 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/VACMS-16278-VA-Police-Query-And-Template December 14, 2023 06:49 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/VACMS-16278-VA-Police-Query-And-Template December 14, 2023 21:09 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/VACMS-16278-VA-Police-Query-And-Template December 14, 2023 22:57 Inactive
@eselkin eselkin marked this pull request as ready for review December 15, 2023 00:25
@eselkin eselkin requested review from a team as code owners December 15, 2023 00:25
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/VACMS-16278-VA-Police-Query-And-Template December 15, 2023 04:39 Inactive
@eselkin eselkin requested a review from laflannery December 15, 2023 05:19
Copy link

@laflannery laflannery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but just a reminder that the <title> still needs to be updated

@eselkin eselkin requested a review from maxx1128 December 15, 2023 19:33
Copy link
Contributor

@maxx1128 maxx1128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this looks really good to me. I just have a few small pieces of feedback.

src/site/filters/liquid.js Outdated Show resolved Hide resolved
src/site/layouts/vamc_system_va_police.drupal.liquid Outdated Show resolved Hide resolved
src/site/layouts/vamc_system_va_police.drupal.liquid Outdated Show resolved Hide resolved
@eselkin eselkin requested a review from maxx1128 December 16, 2023 00:47
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/VACMS-16278-VA-Police-Query-And-Template December 16, 2023 00:51 Inactive
Copy link
Contributor

@maxx1128 maxx1128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@chriskim2311 chriskim2311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eselkin eselkin merged commit 88855d9 into main Dec 19, 2023
22 checks passed
@eselkin eselkin deleted the VACMS-16278-VA-Police-Query-And-Template branch December 19, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants