Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS 19842 - conditional rendering of data-widget-type div or full-width-banners based on CMS toggle #2377

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

eselkin
Copy link
Contributor

@eselkin eselkin commented Dec 6, 2024

Summary

  • Puts div for React widget injection next to full width banners in header.html and makes it conditional based on CMS toggle
  • Sitewide team
  • CMS toggle FEATURE_BANNER_USE_ALTERNATIVE_BANNERS

Related issue(s)

Testing done

  • Conditionally renders the div with the widget type for using vets-website banner when toggled feature is on and uses standard existing div with va-banner from graphql if off.
  • Manually tested two builds on a tugboat

Screenshots

Build with FEATURE_BANNER_USE_ALTERNATIVE_BANNERS: true but tugboat doesn't build the new v-w so div is blank (but still no full-width-banner from liquid template) Screenshot 2024-12-06 at 10 32 32 AM
Build with FEATURE_BANNER_USE_ALTERNATIVE_BANNERS: false Screenshot 2024-12-06 at 11 30 55 AM

What areas of the site does it impact?

Affects the pages in VAMC systems (including va-manila-clinic which is a system to itself) for the full-width banners under the header

Acceptance criteria

  • When CMS feature toggle FEATURE_BANNER_USE_ALTERNATIVE_BANNERS is enabled, in content-build, the existing prod build of VAMC BwSU should disappear across ALL templates

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

Check a tugboat build with /admin/config/system/feature_toggle on and off for FEATURE_BANNER_USE_ALTERNATIVE_BANNERS
this was done on https://main-pjrkdo5kzgprzxpfz31rnvzleiegcmh4.demo.cms.va.gov/admin/config/system/feature_toggle

@eselkin eselkin marked this pull request as ready for review December 6, 2024 18:23
@eselkin eselkin requested review from a team as code owners December 6, 2024 18:23
Copy link
Contributor

@SnowboardTechie SnowboardTechie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@rmessina1010 rmessina1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eselkin eselkin merged commit c84ac53 into main Dec 6, 2024
27 checks passed
@eselkin eselkin deleted the VACMS-19842-vets-api-FullWidthBanners branch December 6, 2024 19:33
timcosgrove pushed a commit that referenced this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants