Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Prod flag for 5490 fry/dea application #2378

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

bradbergeron-us
Copy link
Contributor

Summary

Turns Production Flag ON for application survivor-dependent-education-benefit-22-5490

Related issue(s)

Testing done

Screenshots

Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).

Before After
Mobile
Desktop

What areas of the site does it impact?

Enables application survivor-dependent-education-benefit-22-5490 in Production

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

@bradbergeron-us bradbergeron-us requested review from a team as code owners December 6, 2024 19:58
Copy link
Contributor

@7hunderbird 7hunderbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link

@IGallupSoCo IGallupSoCo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@7hunderbird 7hunderbird merged commit 5e9fa63 into main Dec 6, 2024
22 of 23 checks passed
@7hunderbird 7hunderbird deleted the 5490-survivor-fry-dea-application-for-prod-flag branch December 6, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants