Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update title text for the HCA app entry #2403

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

longmd
Copy link
Contributor

@longmd longmd commented Dec 30, 2024

Summary

This PR updates the title text of the HCA application to match the H1 tag and current breadcrumb for the app page. This update was based on a finding from Staging review of other team app that uncovered the mismatch.

Related issue(s)

department-of-veterans-affairs/va.gov-team#99709

Acceptance criteria

  • Page title text matches the current breadcrumb and H1 tag on the page

Quality Assurance & Testing

  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution

Copy link
Contributor

@rmessina1010 rmessina1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@longmd longmd merged commit 9ee6174 into main Jan 6, 2025
24 checks passed
@longmd longmd deleted the longmd-99709-hca-title-text-update branch January 6, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants