API-34013 ICN error regression test fix #483
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwise-va
reviewed
Feb 14, 2024
|
I was able to get passing regression test on master by setting the following: I understand you already tried to deploy with ICN_ERROR_USER_EMAIL= 2024 007 test user. Although, my local setup is passing with this. Curious why this is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to temporarily alter the icn_error regression test to add a separate env password var so that it can use the old account's password instead of relying on the new id.me accounts. The reason for this change is because there is no valid user in the new id.me test accounts for the icn_error test to use.
Link to Jira: https://jira.devops.va.gov/browse/API-34013