Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regular Update for Dependencies #2184

Closed
8 of 14 tasks
github-actions bot opened this issue Dec 16, 2024 · 3 comments
Closed
8 of 14 tasks

Regular Update for Dependencies #2184

github-actions bot opened this issue Dec 16, 2024 · 3 comments

Comments

@github-actions
Copy link

github-actions bot commented Dec 16, 2024

User Story - Business Need

We wish to keep dependencies up to date so that we do not need such massive overhauls of our system. This is a recurring task to update all dependencies we are able to update. Any conflicts shall get a dedicated ticket. This task should be a day of work at most because it only updates non-breaking changes.

  • Ticket is understood and QA has been contacted

User Story

As VA Notify,
I want to keep our service up to date
So that we are secure and as free of bugs as possible.

Additional Info and Resources

  • Relevant section of README.md
  • Troubleshooting tips:
    • When looking at changes in poetry.lock, revert major changes, then minor, then patch/security: never edit this file manually!

Engineering Checklist

  • Review "Tech Debt" tickets in backlog to identify packages already known to have breaking changes (don't try to upgrade these)
    • pro-tip: these should be pinned down to a specific version in the pyproject.toml file
  • Review open Dependabot PRs to determine where the changes will take place (open them and look at the files touched).
    • Add the comment @dependabot rebase to any open Dependbot PRs
    • DO NOT otherwise modify any Dependabot PR
    • Upgrade to the latest versions first, regardless of what Dependabot reports.
  • Update performed per the README.md
  • Passes all tests locally
  • Passes QA Suite regression testing against Dev
  • If there are any failures, compare the poetry.lock in main against your local poetry.lock.
    • Identify the discrepancies and lock those versions in pyproject.toml, create a ticket, and label it "tech debt"
    • Any non-top level dependencies that have to be locked should have a comment added to pyproject.toml and have a checkbox to remove that dependency from pyproject.toml in the acceptance criteria
    • Created ticket has the package name in the title

Acceptance Criteria

Repo dependencies are updated and we have no broken functionality. Issues opened by Dependabot are resolved. Tickets with the "tech debt" label created for any updates we could, or should, not do.

  • This work is added to the sprint review slide deck (key win bullet point and demo slide)

QA Considerations

  • Affected Dependabot PRs are closed after merge (may need to rebase them using dependabot command)
  • Check to see if these updates cancel out any Twistlock issues
  • QA Regression tests pass after deploying this code.
@npmartin-oddball
Copy link

@kalbfled Compare this ticket to the template and add missing items to template. Also add mention of requirements.txt to template.

kalbfled added a commit that referenced this issue Dec 24, 2024
@kalbfled kalbfled mentioned this issue Dec 24, 2024
15 tasks
kalbfled added a commit that referenced this issue Dec 24, 2024
kalbfled added a commit that referenced this issue Dec 24, 2024
@kalbfled kalbfled mentioned this issue Dec 24, 2024
5 tasks
@kalbfled
Copy link
Member

I marked this ticket as off track because I had to spend time figuring out that I needed to pin ddtrace to avoid deployment failures. I opened #2203. QA work also remains, and Cris is on vacation.

kalbfled added a commit that referenced this issue Dec 24, 2024
@k-macmillan
Copy link
Member

Forgot to comment that this was tested and is working as expected. All GHA and requirements.txt were good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants