Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add page 'Help users update prefilled information' as a draft page #3562

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

adamwhitlock1
Copy link
Contributor

@adamwhitlock1 adamwhitlock1 commented Dec 3, 2024

Description:

Adds a page for 'Help users update prefilled information'. This PR also updates some minor content within the 'Know when their information is prefilled'

Associated ticket:
department-of-veterans-affairs/tmf-auth-exp-design-patterns#253 (comment)

@adamwhitlock1 adamwhitlock1 changed the title add prelim content for page Add page 'Help users update prefilled information' as a draft page Dec 17, 2024
@adamwhitlock1 adamwhitlock1 marked this pull request as ready for review December 17, 2024 00:06
@adamwhitlock1 adamwhitlock1 requested a review from a team as a code owner December 17, 2024 00:06
Copy link
Collaborator

@humancompanion-usds humancompanion-usds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this is very good. Thanks for putting it all together. Left just a few comments of things to tighten up.

@adamwhitlock1
Copy link
Contributor Author

@humancompanion-usds Thank you for the review and suggestions.

I have made the requested changes, and the newest version of the page is available for reveiw here: https://dev-design.va.gov/3562/patterns/help-users-to/update-prefilled-information


### When not to use this pattern

- **When you don't prefill the user's information.**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should match the other pattern where we say that you can't use this pattern when the user is not authenticated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants