-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VACMS-15699 Clean up code in the header/footer directories #26524
Conversation
9a636c1
to
4fd7a53
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ESLint is disabled
vets-website
uses ESLint to help enforce code quality. In most situations we would like ESLint to remain enabled.
What you can do
See if the code can be refactored to avoid disabling ESLint, or wait for a VSP review.
08648dc
to
e276671
Compare
e276671
to
7e06b05
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Nice work on the clean up!
Summary
Cleaning up unnecessary comments in the header/footer code. Also refactored
/platform
imports to~/platform
to satisfy the local linter (this is the same and has been used many times across the repository).No functionality changes expected. This is cleanup I'm doing as part of the header/footer unit/Cypress test audit and expansion.
Related issue(s)