Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-15699 Clean up code in the header/footer directories #26524

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

randimays
Copy link
Contributor

@randimays randimays commented Nov 2, 2023

Summary

Cleaning up unnecessary comments in the header/footer code. Also refactored /platform imports to ~/platform to satisfy the local linter (this is the same and has been used many times across the repository).

No functionality changes expected. This is cleanup I'm doing as part of the header/footer unit/Cypress test audit and expansion.

Related issue(s)

@randimays randimays requested review from a team as code owners November 2, 2023 16:44
@randimays randimays force-pushed the 15699-remove-comments branch from 9a636c1 to 4fd7a53 Compare November 2, 2023 16:51
Copy link

@va-vfs-bot va-vfs-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint is disabled

vets-website uses ESLint to help enforce code quality. In most situations we would like ESLint to remain enabled.

What you can do

See if the code can be refactored to avoid disabling ESLint, or wait for a VSP review.

@randimays randimays force-pushed the 15699-remove-comments branch 2 times, most recently from 08648dc to e276671 Compare November 2, 2023 16:55
@va-vfs-bot va-vfs-bot temporarily deployed to master/15699-remove-comments/main November 2, 2023 16:59 Inactive
Copy link
Contributor

@rmessina1010 rmessina1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@chriskim2311 chriskim2311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Nice work on the clean up!

@randimays randimays merged commit fca50ba into main Nov 3, 2023
92 checks passed
@randimays randimays deleted the 15699-remove-comments branch November 3, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants