Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MHV-62497 Failure-Of-PHR-Refresh-Status-Check-Is-Not-Handled #33087

Merged

Conversation

tynyttie
Copy link
Contributor

@tynyttie tynyttie commented Nov 19, 2024

Summary

Update NewRecordsIndicator to include CALL_FAILED to handle the failure status of API calls.

Related issue(s)

MHV-62497 - Failure of PHR refresh status check is not handled

Failure of PHR refresh status check is not handled

Currently we are not handling the failure of the /status API call. Identify what happens if this status check fails, then come up with a plan to remediate this.

I started a discussion about this here: https://dsva.slack.com/archives/C04ER7MHX5E/p1729180324631989

User Story: As a Medical Records team, we want to be certain we are handling the failure of the /status API calls so that we can plan a remediation for this issue.

GIVEN

WHEN

THEN

Feature Flag N

DataDog/Analytics N

Manual Testing - Y

Automated Testing Y/N ?

Accessibility Testing N

UCD Validation Y/N

Acceptance Criteria:

AC1 Log this issue in the playbook

AC2 PHR refresh failure status is handled correctly

AC3
AC4
AC5

Links to UCD:

Figma Link:

User Flow:

Mobile:

Desktop:

Other Design Notes:

Architectural Notes: Always check for the latest designs in Figma

Other Design Notes:

Testing done

Conducted UI testing to ensure the expected behavior. I updated existing unit test for new components.

Screenshots

Screenshot 2024-11-20 at 9 09 24 AM (3)

What areas of the site does it impact?

The modification affects all API calls in Medical Records pages.

Acceptance criteria

Inclusion of CALL_FAILED Status:

  1. The NewRecordsIndicator must be updated to include a new status called CALL_FAILED.
    This status will be used to represent API calls that have failed.

Correct Handling of API Failures:

  1. When an API call fails, the CALL_FAILED status must be triggered in the NewRecordsIndicator.
    The CALL_FAILED status should be applied only in cases where the API call returns an error or fails to complete successfully (e.g., network errors, server errors).

UI Updates:

  1. The UI should display the CALL_FAILED status appropriately, either by showing an error message or updating the indicator to reflect the failure state.
    The CALL_FAILED status should be distinguishable from other statuses (e.g., by using an error icon or a red color to indicate failure).

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Summary

Update lkfja)

MHV-61246 - Add the "Last updated" text to the print view for List pages

Add the "Last updated" text to the print view for List pages

The NewRecordsIndicator has been removed from the print view, because it was printing the spinner, but we probably want to print something there.

Work with UCD to decide how it should look when printed in various scenarios, then implement inside NewRecordsIndicator.

User Story: As a MR user, I want to so that I can

GIVEN:

WHEN:

THEN:

Feature Flag Y/N ?

DataDog Analytics Y/N ?

Manual Testing Y/N ?

Automated Testing Y/N ?

Accessibility Testing Y/N ?

UCD Validation Y/N

Acceptance Criteria:

AC1

AC2

AC3

AC4

Links to UCD:

Figma Link:

Other Design Notes:

Testing done

Conducted UI testing to ensure the expected behavior. I updated existing unit test for new components.

Screenshots

What areas of the site does it impact?

The modification affects the Vitals Detail page in Medical Records pages.

Acceptance criteria

The focus shifts back to the title when pagination navigates to the first page.

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

@va-vfs-bot va-vfs-bot temporarily deployed to master/MHV-62497-Failure-Of-PHR-Refresh-Status-Check-Is-Not-Handled/main November 19, 2024 00:50 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/MHV-62497-Failure-Of-PHR-Refresh-Status-Check-Is-Not-Handled/main November 19, 2024 15:47 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/MHV-62497-Failure-Of-PHR-Refresh-Status-Check-Is-Not-Handled/main November 20, 2024 14:46 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/MHV-62497-Failure-Of-PHR-Refresh-Status-Check-Is-Not-Handled/main November 20, 2024 16:11 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/MHV-62497-Failure-Of-PHR-Refresh-Status-Check-Is-Not-Handled/main November 25, 2024 21:47 Inactive
@tynyttie tynyttie requested a review from mmoyer-va November 26, 2024 14:42
@va-vfs-bot va-vfs-bot temporarily deployed to master/MHV-62497-Failure-Of-PHR-Refresh-Status-Check-Is-Not-Handled/main November 26, 2024 14:42 Inactive
Copy link
Contributor

@mmoyer-va mmoyer-va left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, looks good!

@tynyttie tynyttie marked this pull request as ready for review November 26, 2024 16:59
@tynyttie tynyttie requested review from a team as code owners November 26, 2024 16:59
@tynyttie tynyttie merged commit 817e529 into main Nov 26, 2024
82 of 85 checks passed
@tynyttie tynyttie deleted the MHV-62497-Failure-Of-PHR-Refresh-Status-Check-Is-Not-Handled branch November 26, 2024 17:33
Khoa-V-Nguyen pushed a commit that referenced this pull request Dec 16, 2024
* Created failure of PHR refresh status check is not handled

* Removed console.logs and add if statement to useMemo in NewRecordIndicator

* Added call_failed to spec file

* Update refesh spec getPhase block

* Added the correct data-testid, Updated the format of test and replace the original conditions to refresth.js

* Returned refresh spec to previous code.

* Fixed the call number link

* Added a space in back later
@tynyttie tynyttie restored the MHV-62497-Failure-Of-PHR-Refresh-Status-Check-Is-Not-Handled branch January 21, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants