-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MHV-62497 Failure-Of-PHR-Refresh-Status-Check-Is-Not-Handled #33087
Merged
tynyttie
merged 12 commits into
main
from
MHV-62497-Failure-Of-PHR-Refresh-Status-Check-Is-Not-Handled
Nov 26, 2024
Merged
MHV-62497 Failure-Of-PHR-Refresh-Status-Check-Is-Not-Handled #33087
tynyttie
merged 12 commits into
main
from
MHV-62497-Failure-Of-PHR-Refresh-Status-Check-Is-Not-Handled
Nov 26, 2024
+58
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vfs-bot
temporarily deployed
to
master/MHV-62497-Failure-Of-PHR-Refresh-Status-Check-Is-Not-Handled/main
November 19, 2024 00:50
Inactive
va-vfs-bot
temporarily deployed
to
master/MHV-62497-Failure-Of-PHR-Refresh-Status-Check-Is-Not-Handled/main
November 19, 2024 15:47
Inactive
va-vfs-bot
temporarily deployed
to
master/MHV-62497-Failure-Of-PHR-Refresh-Status-Check-Is-Not-Handled/main
November 20, 2024 14:46
Inactive
va-vfs-bot
temporarily deployed
to
master/MHV-62497-Failure-Of-PHR-Refresh-Status-Check-Is-Not-Handled/main
November 20, 2024 16:11
Inactive
mmoyer-va
requested changes
Nov 20, 2024
src/applications/mhv-medical-records/components/shared/NewRecordsIndicator.jsx
Outdated
Show resolved
Hide resolved
src/applications/mhv-medical-records/components/shared/NewRecordsIndicator.jsx
Outdated
Show resolved
Hide resolved
src/applications/mhv-medical-records/tests/reducers/refresh.unit.spec.js
Outdated
Show resolved
Hide resolved
… the original conditions to refresth.js
mmoyer-va
requested changes
Nov 25, 2024
src/applications/mhv-medical-records/components/shared/NewRecordsIndicator.jsx
Outdated
Show resolved
Hide resolved
src/applications/mhv-medical-records/components/shared/NewRecordsIndicator.jsx
Outdated
Show resolved
Hide resolved
va-vfs-bot
temporarily deployed
to
master/MHV-62497-Failure-Of-PHR-Refresh-Status-Check-Is-Not-Handled/main
November 25, 2024 21:47
Inactive
va-vfs-bot
temporarily deployed
to
master/MHV-62497-Failure-Of-PHR-Refresh-Status-Check-Is-Not-Handled/main
November 26, 2024 14:42
Inactive
mmoyer-va
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, looks good!
tynyttie
deleted the
MHV-62497-Failure-Of-PHR-Refresh-Status-Check-Is-Not-Handled
branch
November 26, 2024 17:33
Khoa-V-Nguyen
pushed a commit
that referenced
this pull request
Dec 16, 2024
* Created failure of PHR refresh status check is not handled * Removed console.logs and add if statement to useMemo in NewRecordIndicator * Added call_failed to spec file * Update refesh spec getPhase block * Added the correct data-testid, Updated the format of test and replace the original conditions to refresth.js * Returned refresh spec to previous code. * Fixed the call number link * Added a space in back later
tynyttie
restored the
MHV-62497-Failure-Of-PHR-Refresh-Status-Check-Is-Not-Handled
branch
January 21, 2025 18:22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update
NewRecordsIndicator
to includeCALL_FAILED
to handle the failure status of API calls.Related issue(s)
MHV-62497 - Failure of PHR refresh status check is not handled
Failure of PHR refresh status check is not handled
Currently we are not handling the failure of the /status API call. Identify what happens if this status check fails, then come up with a plan to remediate this.
I started a discussion about this here: https://dsva.slack.com/archives/C04ER7MHX5E/p1729180324631989
User Story: As a Medical Records team, we want to be certain we are handling the failure of the /status API calls so that we can plan a remediation for this issue.
GIVEN
WHEN
THEN
Feature Flag N
DataDog/Analytics N
Manual Testing - Y
Automated Testing Y/N ?
Accessibility Testing N
UCD Validation Y/N
Acceptance Criteria:
AC1 Log this issue in the playbook
AC2 PHR refresh failure status is handled correctly
AC3
AC4
AC5
Links to UCD:
Figma Link:
User Flow:
Mobile:
Desktop:
Other Design Notes:
Architectural Notes: Always check for the latest designs in Figma
Other Design Notes:
Testing done
Conducted UI testing to ensure the expected behavior. I updated existing unit test for new components.
Screenshots
What areas of the site does it impact?
The modification affects all API calls in Medical Records pages.
Acceptance criteria
Inclusion of CALL_FAILED Status:
This status will be used to represent API calls that have failed.
Correct Handling of API Failures:
The CALL_FAILED status should be applied only in cases where the API call returns an error or fails to complete successfully (e.g., network errors, server errors).
UI Updates:
The CALL_FAILED status should be distinguishable from other statuses (e.g., by using an error icon or a red color to indicate failure).
Quality Assurance & Testing
Authentication
Summary
Update lkfja)
MHV-61246 - Add the "Last updated" text to the print view for List pages
Add the "Last updated" text to the print view for List pages
The NewRecordsIndicator has been removed from the print view, because it was printing the spinner, but we probably want to print something there.
Work with UCD to decide how it should look when printed in various scenarios, then implement inside NewRecordsIndicator.
User Story: As a MR user, I want to so that I can
GIVEN:
WHEN:
THEN:
Feature Flag Y/N ?
DataDog Analytics Y/N ?
Manual Testing Y/N ?
Automated Testing Y/N ?
Accessibility Testing Y/N ?
UCD Validation Y/N
Acceptance Criteria:
AC1
AC2
AC3
AC4
Links to UCD:
Figma Link:
Other Design Notes:
Testing done
Conducted UI testing to ensure the expected behavior. I updated existing unit test for new components.
Screenshots
What areas of the site does it impact?
The modification affects the Vitals Detail page in Medical Records pages.
Acceptance criteria
The focus shifts back to the title when pagination navigates to the first page.
Quality Assurance & Testing
Authentication