refactor test command to add a test #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the flags into a struct and added a NewTestCommand to allow for testing of the RunE command.
Initially we followed the Cobra pattern of using a package-level var block to initialize flags, but that led to functions operating on variables that weren't parameters to the function. Now by passing a flag struct around we can write more tests without worrying about "global" state.
Also the amount of flags has slowly grown, so having them all together in a struct is handy. In a future refactor we might push those flags down into the infra package to avoid having to copy them over into the nebulous infra.Params.