more script test tweaks and additions #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, accidentally merge in #212 before I wanted to. Just more tests! |
landongrindheim
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Look at db2c290 for the changes to the test before I moved it. After reading the Go source I saw there's a helper
script.Programthat does what theDependabotfunction was doing so I replaced it.Also noticed that having
dependabot_test.goin an outside package was causing it to not rebuild when making changes to the code. Go has built-in caching so it doesn't re-run tests that don't have any changes. Since the test wasn't directly importing any of the modules then it couldn't tell there were changes. Putting it in the package that imports the rest of the project fixes that.Plus it just makes more sense for it to be next to
dependabot.go.Also added more tests! It's so easy to write these it's kind of fun.