Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump go from 1.22.0 to 1.22.1 #292

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Bump go from 1.22.0 to 1.22.1 #292

merged 2 commits into from
Mar 5, 2024

Conversation

JamieMagee
Copy link
Contributor

@JamieMagee JamieMagee requested a review from a team as a code owner March 5, 2024 22:16
mctofu
mctofu approved these changes Mar 5, 2024
View reviewed changes
Copy link

@mctofu mctofu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also consider specifying the full patch version in go.mod and configuring the actions to use the version from there. Then we'll have fewer places to update the version on the next minor bump.

@JamieMagee
Copy link
Contributor Author

@mctofu good suggestion. Done!

@JamieMagee JamieMagee enabled auto-merge March 5, 2024 23:39
@JamieMagee JamieMagee added this pull request to the merge queue Mar 5, 2024
Merged via the queue into main with commit 8e85cac Mar 5, 2024
70 checks passed
@JamieMagee JamieMagee deleted the users/jamagee/go-1.22.1 branch March 5, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mctofu mctofu mctofu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JamieMagee @mctofu