Skip to content

Commit

Permalink
Simplify group updates by dep type test to fix CI (#8344)
Browse files Browse the repository at this point in the history
Just check that only prod (and not dev) dependencies are updated (and
the other way around for the opposite situation), instead of asserting
for exact lockfiles, which are brittle to releases of transitive
dependencies.
  • Loading branch information
deivid-rodriguez authored Nov 6, 2023
1 parent 94848f7 commit 23f7c6f
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 83 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@
gemfile_lock = dependency_change.updated_dependency_files.find do |file|
file.path == "/Gemfile.lock"
end
expect(gemfile_lock.content).to eql(fixture("bundler_grouped_by_types/updated_development_deps/Gemfile.lock"))
expect(gemfile_lock.content).to include("rubocop (1.56.0)").and include("rack (2.1.3)")
end

expect(mock_service).to receive(:create_pull_request) do |dependency_change|
Expand All @@ -251,7 +251,7 @@
gemfile_lock = dependency_change.updated_dependency_files.find do |file|
file.path == "/Gemfile.lock"
end
expect(gemfile_lock.content).to eql(fixture("bundler_grouped_by_types/updated_production_deps/Gemfile.lock"))
expect(gemfile_lock.content).to include("rubocop (0.75.0)").and include("rack (3.0.8)")
end

group_update_all.perform
Expand Down

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ job:
ignore-conditions:
- dependency-name: rubocop
version-requirement: "> 1.56.0"
- dependency-name: rack
version-requirement: "> 3.0.8"
requirements-update-strategy:
allowed-updates:
- dependency-type: direct
Expand Down

0 comments on commit 23f7c6f

Please sign in to comment.