Increase default timeout for helper subprocess commands from 2 minute…

…s to 15 minutes (#11153)
dependabot · Dec 19, 2024 · 5fabd3d · 5fabd3d
1 parent ba0bbf8
commit 5fabd3d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/common/lib/dependabot/command_helpers.rb b/common/lib/dependabot/command_helpers.rb
@@ -11,11 +11,11 @@ module CommandHelpers
     extend T::Sig
 
     module TIMEOUTS
-      NO_TIME_OUT = -1
-      LOCAL = 30
-      NETWORK = 120
-      LONG_RUNNING = 300
-      DEFAULT = NETWORK
+      NO_TIME_OUT = -1 # No timeout
+      LOCAL = 30 # 30 seconds
+      NETWORK = 120 # 2 minutes
+      LONG_RUNNING = 300 # 5 minutes
+      DEFAULT = 900 # 15 minutes
     end
 
     class ProcessStatus

diff --git a/common/lib/dependabot/shared_helpers.rb b/common/lib/dependabot/shared_helpers.rb
@@ -453,7 +453,7 @@ def self.run_shell_command(command,
 
       env_cmd = [env || {}, cmd, opts].compact
       if Experiments.enabled?(:enable_shared_helpers_command_timeout)
-        stdout, stderr, process, _elapsed_time = CommandHelpers.capture3_with_timeout(
+        stdout, stderr, process = CommandHelpers.capture3_with_timeout(
           env_cmd,
           stderr_to_stdout: stderr_to_stdout,
           timeout: timeout