Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes pip-compile file matcher for metric collection #11174

Merged
merged 2 commits into from
Dec 27, 2024

Conversation

sachin-sandhu
Copy link
Contributor

@sachin-sandhu sachin-sandhu commented Dec 23, 2024

What are you trying to accomplish?

Fixed issue where we were not able to capture pip-compile package manager in metric collection.

Anything you want to highlight for special attention from reviewers?

How will you know you've accomplished your goal?

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@sachin-sandhu sachin-sandhu self-assigned this Dec 23, 2024
@sachin-sandhu sachin-sandhu marked this pull request as ready for review December 23, 2024 10:06
@sachin-sandhu sachin-sandhu requested a review from a team as a code owner December 23, 2024 10:06
Copy link
Contributor

@amazimbe amazimbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need an additional test?

@sachin-sandhu sachin-sandhu force-pushed the ssandhu-fixes-pip-compile-detect branch 2 times, most recently from 5e9bcf7 to ec8b302 Compare December 23, 2024 16:08
@sachin-sandhu sachin-sandhu force-pushed the ssandhu-fixes-pip-compile-detect branch from ec8b302 to 57dad3f Compare December 27, 2024 13:33
@sachin-sandhu sachin-sandhu force-pushed the ssandhu-fixes-pip-compile-detect branch from 57dad3f to eb63f7c Compare December 27, 2024 13:45
@sachin-sandhu sachin-sandhu merged commit c1d2edc into main Dec 27, 2024
60 checks passed
@sachin-sandhu sachin-sandhu deleted the ssandhu-fixes-pip-compile-detect branch December 27, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants