-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Detected Version to Base Version Manager and Update Ecosystem Package Managers and Languages #11190
base: main
Are you sure you want to change the base?
Conversation
raw_version: version_manager.version.to_semver.to_s, | ||
version: version_manager.version.to_s, | ||
raw_version: raw_version.empty? ? "N/A" : raw_version, | ||
version: version.empty? ? "N/A" : version, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Tip: We want to send N/A
for non version package managers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per the conversation, this change is more than improving readability. there are business cases where it will differ.
Additionally, I do see added explicit null check been added.
I approve it.
What are you trying to accomplish?
This pull request introduces the
detected_version
parameter to theVersionManager
base class and updates all package manager and language-specific implementations to use explicit named parameters during initialization.The rationale behind this change is to enhance clarity and maintainability. Currently, package managers and languages are used for deprecation/unsupported functionality and metrics collection related to package manager and language versions during Dependabot runs. Since the
detected_version
and the existingversion
parameter represent distinct concepts, this update ensures they remain separate in the codebase, reducing potential confusion and improving maintainability.Why?
detected_version
andversion
.This change aims to eliminate ambiguity in parameter handling while aligning with best practices for code readability and robustness.
Anything you want to highlight for special attention from reviewers?
How will you know you've accomplished your goal?
detected_version
integration.Checklist